use timeToDisplayTracker from options, remove timeToDisplayTracker fr…

…om navigator ctor
getsentry · Oct 8, 2024 · 7d08c83 · 7d08c83
1 parent c12cab3
commit 7d08c83
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 16 deletions.
diff --git a/flutter/lib/src/navigation/sentry_navigator_observer.dart b/flutter/lib/src/navigation/sentry_navigator_observer.dart
@@ -78,7 +78,6 @@ class SentryNavigatorObserver extends RouteObserver<PageRoute<dynamic>> {
     bool setRouteNameAsTransaction = false,
     RouteNameExtractor? routeNameExtractor,
     AdditionalInfoExtractor? additionalInfoProvider,
-    @visibleForTesting TimeToDisplayTracker? timeToDisplayTracker,
     List<String>? ignoreRoutes,
   })  : _hub = hub ?? HubAdapter(),
         _enableAutoTransactions = enableAutoTransactions,
@@ -92,8 +91,7 @@ class SentryNavigatorObserver extends RouteObserver<PageRoute<dynamic>> {
     if (enableAutoTransactions) {
       _hub.options.sdk.addIntegration('UINavigationTracing');
     }
-    _timeToDisplayTracker =
-        timeToDisplayTracker ?? _initializeTimeToDisplayTracker();
+    _timeToDisplayTracker = _initializeTimeToDisplayTracker();
   }
 
   /// Initializes the TimeToDisplayTracker with the option to enable time to full display tracing.
@@ -114,11 +112,7 @@ class SentryNavigatorObserver extends RouteObserver<PageRoute<dynamic>> {
   final AdditionalInfoExtractor? _additionalInfoProvider;
   final SentryNativeBinding? _native;
   final List<String> _ignoreRoutes;
-  static TimeToDisplayTracker? _timeToDisplayTracker;
-
-  @internal
-  static TimeToDisplayTracker? get timeToDisplayTracker =>
-      _timeToDisplayTracker;
+  TimeToDisplayTracker? _timeToDisplayTracker;
 
   ISentrySpan? _transaction;
 

diff --git a/flutter/lib/src/sentry_flutter.dart b/flutter/lib/src/sentry_flutter.dart
@@ -242,7 +242,13 @@ mixin SentryFlutter {
   /// Reports the time it took for the screen to be fully displayed.
   /// This requires the [SentryFlutterOptions.enableTimeToFullDisplayTracing] option to be set to `true`.
   static Future<void> reportFullyDisplayed() async {
-    return SentryNavigatorObserver.timeToDisplayTracker?.reportFullyDisplayed();
+    // ignore: invalid_use_of_internal_member
+    final options = Sentry.currentHub.options;
+    if (options is SentryFlutterOptions) {
+      return options.timeToDisplayTracker.reportFullyDisplayed();
+    } else {
+      return;
+    }
   }
 
   /// Pauses the app hang tracking.

diff --git a/flutter/test/sentry_navigator_observer_test.dart b/flutter/test/sentry_navigator_observer_test.dart
@@ -1044,24 +1044,26 @@ class Fixture {
     bool setRouteNameAsTransaction = false,
     RouteNameExtractor? routeNameExtractor,
     AdditionalInfoExtractor? additionalInfoProvider,
-    bool enableTimeToFullDisplayTracing = false,
     List<String>? ignoreRoutes,
   }) {
     final frameCallbackHandler = FakeFrameCallbackHandler();
-    final timeToInitialDisplayTracker =
-        TimeToInitialDisplayTracker(frameCallbackHandler: frameCallbackHandler);
-    final timeToDisplayTracker = TimeToDisplayTracker(
-      ttidTracker: timeToInitialDisplayTracker,
-      options: hub.options as SentryFlutterOptions,
+    final timeToInitialDisplayTracker = TimeToInitialDisplayTracker(
+      frameCallbackHandler: frameCallbackHandler,
     );
+    final options = hub.options;
+    if (options is SentryFlutterOptions) {
+      options.timeToDisplayTracker = TimeToDisplayTracker(
+        ttidTracker: timeToInitialDisplayTracker,
+        options: hub.options as SentryFlutterOptions,
+      );
+    }
     return SentryNavigatorObserver(
       hub: hub,
       enableAutoTransactions: enableAutoTransactions,
       autoFinishAfter: autoFinishAfter,
       setRouteNameAsTransaction: setRouteNameAsTransaction,
       routeNameExtractor: routeNameExtractor,
       additionalInfoProvider: additionalInfoProvider,
-      timeToDisplayTracker: timeToDisplayTracker,
       ignoreRoutes: ignoreRoutes,
     );
   }