update tests

getsentry · Oct 2, 2024 · b17e607 · b17e607
1 parent 3bd5c5d
commit b17e607
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 14 deletions.
diff --git a/flutter/lib/src/navigation/sentry_navigator_observer.dart b/flutter/lib/src/navigation/sentry_navigator_observer.dart
@@ -161,13 +161,8 @@ class SentryNavigatorObserver extends RouteObserver<PageRoute<dynamic>> {
     _timeToDisplayTracker?.clear();
 
     DateTime timestamp = _hub.options.clock();
-    _finishAndStartTTIDTracking(route, timestamp);
-  }
-
-  Future<void> _finishAndStartTTIDTracking(
-      Route<dynamic>? route, DateTime timestamp) async {
-    await _finishTimeToDisplayTracking(endTimestamp: timestamp);
-    await _startTimeToDisplayTracking(route, timestamp);
+    _finishTimeToDisplayTracking(endTimestamp: timestamp);
+    _startTimeToDisplayTracking(route, timestamp);
   }
 
   @override

diff --git a/flutter/test/sentry_navigator_observer_test.dart b/flutter/test/sentry_navigator_observer_test.dart
@@ -317,7 +317,8 @@ void main() {
         expect(scope.span, null);
       });
 
-      verify(span.finish()).called(2);
+      verify(span.finish(endTimestamp: captureAnyNamed('endTimestamp')))
+          .called(2);
     });
 
     test('didPop finishes transaction', () async {
@@ -344,7 +345,8 @@ void main() {
         expect(scope.span, null);
       });
 
-      verify(span.finish()).called(1);
+      verify(span.finish(endTimestamp: captureAnyNamed('endTimestamp')))
+          .called(1);
     });
 
     test('multiple didPop only finish transaction once', () async {
@@ -373,7 +375,8 @@ void main() {
         expect(scope.span, null);
       });
 
-      verify(span.finish()).called(1);
+      verify(span.finish(endTimestamp: captureAnyNamed('endTimestamp')))
+          .called(1);
     });
 
     test(
@@ -413,9 +416,13 @@ void main() {
 
       await Future<void>.delayed(const Duration(milliseconds: 100));
 
-      verify(mockChildA.finish(status: SpanStatus.deadlineExceeded()))
+      verify(mockChildA.finish(
+              endTimestamp: captureAnyNamed('endTimestamp'),
+              status: SpanStatus.deadlineExceeded()))
           .called(1);
-      verify(mockChildB.finish(status: SpanStatus.deadlineExceeded()))
+      verify(mockChildB.finish(
+              endTimestamp: captureAnyNamed('endTimestamp'),
+              status: SpanStatus.deadlineExceeded()))
           .called(1);
     });
 
@@ -456,9 +463,13 @@ void main() {
 
       await Future<void>.delayed(const Duration(milliseconds: 100));
 
-      verify(mockChildA.finish(status: SpanStatus.deadlineExceeded()))
+      verify(mockChildA.finish(
+              endTimestamp: captureAnyNamed('endTimestamp'),
+              status: SpanStatus.deadlineExceeded()))
           .called(1);
-      verify(mockChildB.finish(status: SpanStatus.deadlineExceeded()))
+      verify(mockChildB.finish(
+              endTimestamp: captureAnyNamed('endTimestamp'),
+              status: SpanStatus.deadlineExceeded()))
           .called(1);
     });