Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Cocoa to 7.1.3 and use PrivateSentrySDKOnly instead of the private headers #477

Closed
marandaneto opened this issue May 28, 2021 · 5 comments · Fixed by #488
Closed

Bump Cocoa to 7.1.3 and use PrivateSentrySDKOnly instead of the private headers #477

marandaneto opened this issue May 28, 2021 · 5 comments · Fixed by #488
Assignees

Comments

@marandaneto
Copy link
Contributor

This is a private class for our SDK that exposes some stuff that is needed, eg for envelopes #391
that are more things that can be removed I guess eg the private header

@ueman
Copy link
Collaborator

ueman commented May 29, 2021

I think @denrase already done it in 60cde6d

@denrase
Copy link
Collaborator

denrase commented May 29, 2021

Yeah, needed to bump in order to use the new API.

@marandaneto
Copy link
Contributor Author

The new class has more methods used by the sdk, so the bump is indeed done but not removing the old private header hacky solution

@marandaneto
Copy link
Contributor Author

eg https://github.com/getsentry/sentry-dart/blob/main/flutter/ios/Classes/SentrySDK%2BFlutterPrivate.h could be removed in favor of PrivateSentrySDKOnly

@marandaneto
Copy link
Contributor Author

I know the bump has been done already on #391 but that PR lands only on v6 and I'd like to bring this improvement into 5.1 too

@ueman ueman mentioned this issue Jun 4, 2021
5 tasks
@ueman ueman self-assigned this Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants