Implement envelope based transport #391

denrase · 2021-03-29T12:17:39Z

📜 Description

Implemented envelope based transport of events.

Open Questions

Can we remove file based envelope transport? -> No
Should hints be implemented as well? -> Later
Do we need to update interface of hubs? -> No

💡 Motivation and Context

With envelopes, we can implement features like feedback and attachments.

Closes #344

💚 How did you test it?

📝 Checklist

🔮 Next steps

Update accordingly when open questions are answered...

…t objects

codecov-io · 2021-03-29T12:19:52Z

Codecov Report

Merging #391 (94c2099) into main (4d42b29) will increase coverage by 2.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
+ Coverage   90.74%   93.16%   +2.41%     
==========================================
  Files          52        5      -47     
  Lines        1654      161    -1493     
==========================================
- Hits         1501      150    -1351     
+ Misses        153       11     -142

Impacted Files	Coverage Δ
flutter/lib/src/sentry_flutter.dart	`93.54% <ø> (ø)`
flutter/lib/src/file_system_transport.dart	`100.00% <100.00%> (ø)`
dart/lib/src/throwable_mechanism.dart
dart/lib/src/protocol/debug_meta.dart
dart/lib/src/protocol/sdk_version.dart
dart/lib/src/protocol/sentry_browser.dart
dart/lib/src/protocol/sentry_message.dart
dart/lib/src/hub.dart
dart/lib/src/protocol/sentry_package.dart
dart/lib/src/protocol/sentry_device.dart
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d42b29...94c2099. Read the comment docs.

dart/lib/src/sentry_envelope.dart

denrase · 2021-05-25T09:18:45Z

@marandaneto Fixed

CHANGELOG.md

flutter/ios/Classes/SentryFlutterPluginApple.swift

marandaneto · 2021-05-26T11:42:02Z

@denrase I'd just figure out if we can do something about https://github.com/getsentry/sentry-dart/pull/391/files#r639644591 otherwise ready to go, thanks for all the work, this will unblock us in so many ways :)

…(with: data)

denrase · 2021-05-28T12:57:23Z

@marandaneto We now use PrivateSentrySDKOnly exposed method instead of accessing private API, thx @philipphofmann for the PR! 🙇

CHANGELOG.md

marandaneto · 2021-05-31T08:05:16Z

@denrase could you fix the conflicts? we are ready to merge if we solve the open comments + conflicts, thanks a lot

marandaneto

LGTM

# Conflicts: # dart/test/sentry_client_test.dart

philipphofmann · 2021-06-01T14:45:11Z

@marandaneto We now use PrivateSentrySDKOnly exposed method instead of accessing private API, thx @philipphofmann for the PR! 🙇

No problem @denrase. The thing with the private headers can break easily and we needed to improve this.

marandaneto · 2021-06-07T12:22:13Z

@denrase 5.1 has been released so we can merge to main, would you mind fixing the conflicts last time? sorry about that :(
feel free to press green too ^^

denrase · 2021-06-08T07:04:02Z

@marandaneto Will do, thanks!

# Conflicts: # flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt # flutter/ios/Classes/SentryFlutterPluginApple.swift

…pe-based-transport # Conflicts: # dart/test/protocol/contexts_test.dart

# Conflicts: # dart/test/protocol/contexts_test.dart

…hub.com/getsentry/sentry-dart into feat/implement-envelope-based-transport # Conflicts: # dart/test/protocol/contexts_test.dart

denrase · 2021-06-08T08:00:25Z

@ueman Ah, was not done yet and also just merging in main

denrase · 2021-06-08T08:27:02Z

Think we are ready! Thanks everyone for the support and feedback! 🙇

denrase added 20 commits March 26, 2021 10:10

Add empty classes for envelopes

74d47e7

Add properties

8e770aa

Create envelope classes from event

737c6f8

introduce serialize method

c0e4b68

Serialize SentryEnvelopeItemHeader

70150b2

Implement serialize of SentryEnvelopeItem

446e04a

Implement serialize and fromEvent for SentryEnvelopeItem

f8a839e

Implement serialize of SentryEnvelopeItemHeader

13826d5

Implement SentryEnvelope

42b6072

Add rste limit category

c99aa8c

add empty rate limiter

47a01d7

Add empty tests for rate limiter

0831a4c

parse rate limit header

d9752d3

Implement RateLimitParser

e60c8d4

Move out decision what to parse

5136095

Own class for RateLimitParser, return map instead of list of RateLimi…

2c44b15

…t objects

Port java rate limiter tests

a34e1c3

implement rate limiter, fix rate limit parser

ab88d44

Support multiple rate limits for same category

36efe03

Merge branch 'main' into feat/implement-envelope-based-transport

94d4b8a

denrase self-assigned this Mar 29, 2021

No generated mock for cdtp

c6d3b35

ueman reviewed Mar 29, 2021

View reviewed changes

dart/lib/src/sentry_envelope.dart Outdated Show resolved Hide resolved

denrase added 5 commits April 6, 2021 14:45

Use envelope endpoint

53e31b3

Handle envelope data in test

1bf198b

Fallback to empty

f4a97be

update retry after limits

7c2529e

test ratelimiter integration into http_transport

e35c4c8

Envelope Only Transport API (#426)

f9a4bae

marandaneto reviewed May 26, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

marandaneto reviewed May 26, 2021

View reviewed changes

flutter/ios/Classes/SentryFlutterPluginApple.swift Outdated Show resolved Hide resolved

denrase added 2 commits May 28, 2021 14:16

Move new changelog items to unrealeased section

739fe04

Bump sentry-cocoa version to 7.1.3, Use PrivateSentrySDKOnly.envelope…

60cde6d

…(with: data)

marandaneto reviewed May 28, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

marandaneto mentioned this pull request May 28, 2021

Bump Cocoa to 7.1.3 and use PrivateSentrySDKOnly instead of the private headers #477

Closed

marandaneto approved these changes May 31, 2021

View reviewed changes

denrase added 2 commits May 31, 2021 10:42

Merge branch 'main' into feat/implement-envelope-based-transport

b6c7485

# Conflicts: # dart/test/sentry_client_test.dart

Update changelog

7650f82

ueman added the 6.0.0 label Jun 6, 2021

denrase and others added 4 commits June 8, 2021 09:18

Merge branch 'main' into feat/implement-envelope-based-transport

e8dc883

# Conflicts: # flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt # flutter/ios/Classes/SentryFlutterPluginApple.swift

Merge remote-tracking branch 'origin/main' into feat/implement-envelo…

32fc143

…pe-based-transport # Conflicts: # dart/test/protocol/contexts_test.dart

Merge branch 'main' into feat/implement-envelope-based-transport

3e90935

# Conflicts: # dart/test/protocol/contexts_test.dart

Update changelog

fbfc409

ueman approved these changes Jun 8, 2021

View reviewed changes

Merge branch 'feat/implement-envelope-based-transport' of https://git…

ba66eb4

…hub.com/getsentry/sentry-dart into feat/implement-envelope-based-transport # Conflicts: # dart/test/protocol/contexts_test.dart

Fix klint issue

99af50a

denrase merged commit 8024a6c into main Jun 8, 2021

denrase deleted the feat/implement-envelope-based-transport branch June 8, 2021 08:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement envelope based transport #391

Implement envelope based transport #391

denrase commented Mar 29, 2021 •

edited

Loading

codecov-io commented Mar 29, 2021 •

edited

Loading

denrase commented May 25, 2021

marandaneto commented May 26, 2021

denrase commented May 28, 2021

marandaneto commented May 31, 2021

marandaneto left a comment

philipphofmann commented Jun 1, 2021

marandaneto commented Jun 7, 2021

denrase commented Jun 8, 2021

denrase commented Jun 8, 2021

denrase commented Jun 8, 2021

Implement envelope based transport #391

Implement envelope based transport #391

Conversation

denrase commented Mar 29, 2021 • edited Loading

📜 Description

Open Questions

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

codecov-io commented Mar 29, 2021 • edited Loading

Codecov Report

denrase commented May 25, 2021

marandaneto commented May 26, 2021

denrase commented May 28, 2021

marandaneto commented May 31, 2021

marandaneto left a comment

Choose a reason for hiding this comment

philipphofmann commented Jun 1, 2021

marandaneto commented Jun 7, 2021

denrase commented Jun 8, 2021

denrase commented Jun 8, 2021

denrase commented Jun 8, 2021

denrase commented Mar 29, 2021 •

edited

Loading

codecov-io commented Mar 29, 2021 •

edited

Loading