Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set min. Flutter version to 2.0.0 #962

Closed
marandaneto opened this issue Jul 26, 2022 · 1 comment · Fixed by #966
Closed

Set min. Flutter version to 2.0.0 #962

marandaneto opened this issue Jul 26, 2022 · 1 comment · Fixed by #966
Labels
flutter flutter repository maintenance
Milestone
7.0.0

Comments

@marandaneto
Copy link
Contributor

marandaneto commented Jul 26, 2022 •
edited
Loading

sentry-dart/flutter/pubspec.yaml

Line 10 in 53b6921

flutter: '>=1.17.0'

https://developers.googleblog.com/2021/03/announcing-flutter-2.html
https://medium.com/dartlang/announcing-dart-2-12-499a6e689c87
https://twitter.com/timsneath/status/1551455025435590656

The current GA version is 3.x already.
Most people use 3.x.
Supporting older APIs have a cost, such as bundle size increase and casting code to dynamic.
People can still use the older version of the Sentry Flutter SDK.

If you are using Flutter 1.x, please let us know.
@marandaneto marandaneto moved this to Needs Discussion in Mobile & Cross Platform SDK Jul 26, 2022
@marandaneto marandaneto added this to the 7.0.0 milestone Jul 26, 2022
@marandaneto
Copy link
Contributor Author

marandaneto commented Jul 26, 2022 •
edited
Loading

Right now only https://github.com/getsentry/sentry-dart/blob/main/flutter/lib/src/sentry_asset_bundle.dart catches NoSuchMethodError and it's for Flutter >= 2.8, so we can't change much here.
We don't have data on the adoption of Flutter for its minor versions, so supporting 2.0.0 seems to be the right decision still.

@marandaneto marandaneto mentioned this issue Jul 27, 2022
Merged
5 tasks
@marandaneto marandaneto moved this from Needs Discussion to In Progress in Mobile & Cross Platform SDK Jul 27, 2022
Repository owner moved this from In Progress to Done in Mobile & Cross Platform SDK Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flutter flutter repository maintenance
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

flutter min version test getsentry/sentry-dart
1 participant
@marandaneto