Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter min version test #966

Merged
merged 22 commits into from
Jul 28, 2022
Merged

flutter min version test #966

merged 22 commits into from
Jul 28, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jul 27, 2022

📜 Description

TODO: changelog
#skip-changelog

Bump Flutter to min 2.0.0
Add CI step that compiles using Flutter's min. supported version now 2.0.0 and Dart 2.12.0
Fix hashCode issue.
Add dependency for logging and dio so they are compiled against the min. version as well.

💡 Motivation and Context

Fixes #962
Fixes #636

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #966 (fc4c7ca) into main (6750ca1) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
+ Coverage   89.51%   89.55%   +0.04%     
==========================================
  Files         105      106       +1     
  Lines        3308     3322      +14     
==========================================
+ Hits         2961     2975      +14     
  Misses        347      347              
Impacted Files Coverage Δ
...lib/src/client_reports/client_report_recorder.dart 100.00% <100.00%> (ø)
dart/lib/src/utils/hash_code.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6750ca1...fc4c7ca. Read the comment docs.

@marandaneto
Copy link
Contributor Author

@ueman found one more issue:

../dart/lib/src/client_reports/client_report_recorder.dart:46:30: Error: Method not found: 'Object.hash'.
  int get hashCode => Object.hash(reason, category);

CHANGELOG.md Show resolved Hide resolved
Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto marked this pull request as ready for review July 28, 2022 08:00
@marandaneto marandaneto merged commit ed46e21 into main Jul 28, 2022
@marandaneto marandaneto deleted the chore/flutter-min-version branch July 28, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set min. Flutter version to 2.0.0 e2e tests should run on min. supported sdk versions
4 participants