-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set custom measurements on transactions #1011
Conversation
Codecov ReportBase: 89.99% // Head: 91.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
+ Coverage 89.99% 91.37% +1.37%
==========================================
Files 113 9 -104
Lines 3539 197 -3342
==========================================
- Hits 3185 180 -3005
+ Misses 354 17 -337 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave this a quick pass and added some comments on the API.
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Users are allowed to set custom measurements
💡 Motivation and Context
Fixes #789
getsentry/team-mobile#31
And getsentry/team-mobile#51
💚 How did you test it?
📝 Checklist
🔮 Next steps