Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set custom measurements on transactions #1011

Merged
merged 14 commits into from
Sep 23, 2022
Merged

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Sep 21, 2022

📜 Description

Users are allowed to set custom measurements

💡 Motivation and Context

Fixes #789
getsentry/team-mobile#31
And getsentry/team-mobile#51

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2022

Codecov Report

Base: 89.99% // Head: 91.37% // Increases project coverage by +1.37% 🎉

Coverage data is based on head (a8a3c07) compared to base (c265311).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1011      +/-   ##
==========================================
+ Coverage   89.99%   91.37%   +1.37%     
==========================================
  Files         113        9     -104     
  Lines        3539      197    -3342     
==========================================
- Hits         3185      180    -3005     
+ Misses        354       17     -337     
Impacted Files Coverage Δ
dart/lib/src/noop_sentry_span.dart
dart/lib/src/protocol/sentry_span.dart
dart/lib/src/protocol/sentry_transaction.dart
dart/lib/src/sentry_measurement.dart
dart/lib/src/sentry_span_interface.dart
dart/lib/src/sentry_tracer.dart
dart/lib/src/sentry.dart
...art/lib/src/http_client/failed_request_client.dart
dart/lib/src/protocol/sentry_level.dart
...art/lib/src/enricher/enricher_event_processor.dart
... and 94 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto marandaneto marked this pull request as ready for review September 21, 2022 12:58
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a quick pass and added some comments on the API.

CHANGELOG.md Outdated Show resolved Hide resolved
dart/lib/src/sentry_measurement.dart Show resolved Hide resolved
dart/lib/src/sentry_measurement_unit.dart Show resolved Hide resolved
dart/lib/src/protocol/sentry_span.dart Show resolved Hide resolved
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
@marandaneto marandaneto changed the title Feat set custom measurement Set custom measurements on transactions Sep 23, 2022
Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom instrumentation to collect slow and frozen frames
5 participants