Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VendorId should be a String #1112

Merged
merged 10 commits into from
Nov 16, 2022
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Fixes

- VendorId should be a String ([#1112](https://github.com/getsentry/sentry-dart/pull/1112))

### Dependencies

- Bump Android SDK from v6.6.0 to v6.7.0 ([#1105](https://github.com/getsentry/sentry-dart/pull/1105))
Expand Down
4 changes: 2 additions & 2 deletions dart/lib/src/protocol/sentry_gpu.dart
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class SentryGpu {
final int? id;

/// The PCI vendor identifier of the graphics device.
final int? vendorId;
final String? vendorId;

/// The vendor name as reported by the graphics device.
final String? vendorName;
Expand Down Expand Up @@ -150,7 +150,7 @@ class SentryGpu {
SentryGpu copyWith({
String? name,
int? id,
int? vendorId,
String? vendorId,
String? vendorName,
int? memorySize,
String? apiType,
Expand Down
8 changes: 4 additions & 4 deletions dart/test/protocol/sentry_gpu_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ void main() {
final sentryGpu = SentryGpu(
name: 'fixture-name',
id: 1,
vendorId: 2,
vendorId: '2',
vendorName: 'fixture-vendorName',
memorySize: 3,
apiType: 'fixture-apiType',
Expand All @@ -17,7 +17,7 @@ void main() {
final sentryGpuJson = <String, dynamic>{
'name': 'fixture-name',
'id': 1,
'vendor_id': 2,
'vendor_id': '2',
'vendor_name': 'fixture-vendorName',
'memory_size': 3,
'api_type': 'fixture-apiType',
Expand Down Expand Up @@ -63,7 +63,7 @@ void main() {
final copy = data.copyWith(
name: 'name1',
id: 11,
vendorId: 22,
vendorId: '22',
vendorName: 'vendorName1',
memorySize: 33,
apiType: 'apiType1',
Expand All @@ -74,7 +74,7 @@ void main() {

expect('name1', copy.name);
expect(11, copy.id);
expect(22, copy.vendorId);
expect('22', copy.vendorId);
expect('vendorName1', copy.vendorName);
expect(33, copy.memorySize);
expect('apiType1', copy.apiType);
Expand Down