Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename APM tracking feature flags to tracing and enable features by default #1222

Merged
merged 11 commits into from
Jan 16, 2023
Merged

Rename APM tracking feature flags to tracing and enable features by default #1222

merged 11 commits into from
Jan 16, 2023

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jan 12, 2023 •
edited
Loading

📜 Description

Rename APM tracking feature flags to tracing and enable features by default

💡 Motivation and Context

Closes #1177

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto changed the title Rename options Rename APM tracking feature flags to tracing and enable features by default Jan 12, 2023
@marandaneto marandaneto requested a review from denrase January 12, 2023 13:02
@marandaneto marandaneto marked this pull request as ready for review January 12, 2023 13:02
This was referenced Jan 12, 2023
Closed
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023 •
edited by codecov bot
Loading

Codecov Report

Base: 89.76% // Head: 88.64% // Decreases project coverage by -1.12% ⚠️

Coverage data is based on head (af596cc) compared to base (eb2f1ff).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@                         Coverage Diff                          @@
##           chore/migrate-to-sentry-cocoa-v8    #1222      +/-   ##
====================================================================
- Coverage                             89.76%   88.64%   -1.13%     
====================================================================
  Files                                   111      122      +11     
  Lines                                  3489     3822     +333     
====================================================================
+ Hits                                   3132     3388     +256     
- Misses                                  357      434      +77
Impacted Files Coverage Δ
dio/lib/src/sentry_dio_client_adapter.dart 83.33% <0.00%> (ø)
dio/lib/src/sentry_transformer.dart 94.44% <0.00%> (ø)
logging/lib/src/extension.dart 100.00% <0.00%> (ø)
dio/lib/src/sentry_dio_extension.dart 92.30% <0.00%> (ø)
dio/lib/src/dio_event_processor.dart 96.42% <0.00%> (ø)
file/lib/src/sentry_file_extension.dart 80.00% <0.00%> (ø)
file/lib/src/sentry_file.dart 54.13% <0.00%> (ø)
dio/lib/src/failed_request_interceptor.dart 100.00% <0.00%> (ø)
logging/lib/src/logging_integration.dart 91.66% <0.00%> (ø)
dio/lib/src/breadcrumb_client_adapter.dart 80.00% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

brustolin
brustolin approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto mentioned this pull request Jan 16, 2023
Merged
5 tasks
denrase
denrase approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, other than that LGTM. Also updated the other PR now to build.

flutter/ios/sentry_flutter.podspec Outdated Show resolved Hide resolved
@denrase
Merge branch 'chore/migrate-to-sentry-cocoa-v8' into chore/rename-opt…
af596cc 
…ions

# Conflicts:
#	flutter/ios/Classes/SentryFlutterPluginApple.swift
#	flutter/ios/sentry_flutter.podspec
krystofwoldrich
krystofwoldrich approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@denrase denrase merged commit ea6679c into chore/migrate-to-sentry-cocoa-v8 Jan 16, 2023
@denrase denrase deleted the chore/rename-options branch January 16, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@brustolin brustolin brustolin approved these changes

@denrase denrase denrase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marandaneto @codecov-commenter @denrase @brustolin @krystofwoldrich