-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support beforeSendTransaction #1238
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Support beforeSendTransaction ([#1238](https://github.com/getsentry/sentry-dart/pull/1238)) If none of the above apply, you can opt out of this check by adding |
Codecov ReportBase: 90.11% // Head: 90.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1238 +/- ##
==========================================
+ Coverage 90.11% 90.13% +0.01%
==========================================
Files 164 164
Lines 5121 5130 +9
==========================================
+ Hits 4615 4624 +9
Misses 506 506
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@denrase follow up about |
@marandaneto Yeah lets do this separate, if theres even something to do. Those are part of the event base class already, you can just never use them in the transaction subclass, but i guess they are not needed there. |
📜 Description
Closes #1151
💚 How did you test it?
Added unit tests
📝 Checklist
🔮 Next steps
@marandaneto There seem to be some oddities with serialization/deserialization with event properties when the instance is a transaction. Maybe it's just an issue in my test setup.