Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support beforeSendTransaction #1238

Merged
merged 8 commits into from
Feb 8, 2023
Merged

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jan 24, 2023

📜 Description

Closes #1151

💚 How did you test it?

Added unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto There seem to be some oddities with serialization/deserialization with event properties when the instance is a transaction. Maybe it's just an issue in my test setup.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Support beforeSendTransaction ([#1238](https://github.com/getsentry/sentry-dart/pull/1238))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against cb25b6a

@denrase denrase marked this pull request as ready for review January 24, 2023 12:53
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 90.11% // Head: 90.13% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b76b18e) compared to base (3e17cfa).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           v7.0.0    #1238      +/-   ##
==========================================
+ Coverage   90.11%   90.13%   +0.01%     
==========================================
  Files         164      164              
  Lines        5121     5130       +9     
==========================================
+ Hits         4615     4624       +9     
  Misses        506      506              
Impacted Files Coverage Δ
dart/lib/src/sentry_options.dart 82.92% <ø> (ø)
dart/lib/src/sentry_client.dart 96.83% <100.00%> (+0.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@denrase denrase requested a review from marandaneto February 6, 2023 11:52
CHANGELOG.md Outdated Show resolved Hide resolved
@denrase denrase requested a review from marandaneto February 7, 2023 09:22
@marandaneto
Copy link
Contributor

@denrase follow up about modules and fingerprint, since we are on the v7 branch, we can move them from the base class to the event class specifically, what do you think? since this is about the beforeSend, we can do it in a follow-up PR.

@denrase
Copy link
Collaborator Author

denrase commented Feb 7, 2023

@marandaneto Yeah lets do this separate, if theres even something to do. Those are part of the event base class already, you can just never use them in the transaction subclass, but i guess they are not needed there.

@marandaneto marandaneto merged commit 231b60b into v7.0.0 Feb 8, 2023
@marandaneto marandaneto deleted the feat/before-send-transaction branch February 8, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants