Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View hierarchy reads size from RenderBox only #1258

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Conversation

marandaneto
Copy link
Contributor

📜 Description

View hierarchy reads size from RenderBox only

💡 Motivation and Context

The current check works but only if the widget itself is a RenderBox and not its renderObject
https://github.com/getsentry/sentry-dart/pull/1189/files#r1080971333

💚 How did you test it?

Running and checking the result

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto mentioned this pull request Feb 1, 2023
5 tasks
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 90.06% // Head: 90.11% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (fa847a7) compared to base (55913de).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           v7.0.0    #1258      +/-   ##
==========================================
+ Coverage   90.06%   90.11%   +0.05%     
==========================================
  Files         164      164              
  Lines        5122     5121       -1     
==========================================
+ Hits         4613     4615       +2     
+ Misses        509      506       -3     
Impacted Files Coverage Δ
...ter/lib/src/view_hierarchy/sentry_tree_walker.dart 100.00% <100.00%> (+7.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto marandaneto merged commit 3e17cfa into v7.0.0 Feb 1, 2023
@marandaneto marandaneto deleted the fix/element-size branch February 1, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants