-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support failedRequestTargets
for HTTP Client errors
#1285
Conversation
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v7.0.0 #1285 +/- ##
==========================================
+ Coverage 88.73% 90.37% +1.63%
==========================================
Files 122 167 +45
Lines 3818 5227 +1409
==========================================
+ Hits 3388 4724 +1336
- Misses 430 503 +73
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@denrase left a few comments but overall, well done.
📜 Description
sentry-java
failedRequestStatusCodes
&failedRequestTargets
in dioFailedRequestInterceptor
failedRequestTargets
inFailedRequestClient
💡 Motivation and Context
Closes #1115
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps
According to documentation the path is described as:
Can someone that is familiar with dio errors point me to samples how the path looks in different scenarios? This might affect how we have to match against
failedRequestTargets
.