-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change podspec EXCLUDED_ARCHS
value
#1303
Conversation
…ore excluded architetures
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1303 +/- ##
=======================================
Coverage 89.82% 89.82%
=======================================
Files 155 155
Lines 5063 5063
=======================================
Hits 4548 4548
Misses 515 515 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c70e01a | 331.04 ms | 401.46 ms | 70.42 ms |
08a7b4f | 346.47 ms | 403.29 ms | 56.82 ms |
eb1a7c1 | 332.98 ms | 381.55 ms | 48.57 ms |
56810ff | 309.72 ms | 352.26 ms | 42.54 ms |
4efee31 | 308.92 ms | 368.68 ms | 59.76 ms |
21d4150 | 379.31 ms | 449.23 ms | 69.93 ms |
1131914 | 317.90 ms | 361.58 ms | 43.69 ms |
457a85b | 312.37 ms | 376.67 ms | 64.31 ms |
379d7a8 | 327.10 ms | 355.39 ms | 28.29 ms |
6325c3b | 339.33 ms | 409.86 ms | 70.53 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c70e01a | 5.94 MiB | 6.97 MiB | 1.03 MiB |
08a7b4f | 5.94 MiB | 6.95 MiB | 1.01 MiB |
eb1a7c1 | 5.94 MiB | 6.92 MiB | 1005.76 KiB |
56810ff | 5.94 MiB | 6.92 MiB | 1001.71 KiB |
4efee31 | 5.94 MiB | 6.92 MiB | 1003.76 KiB |
21d4150 | 5.94 MiB | 6.97 MiB | 1.03 MiB |
1131914 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
457a85b | 6.06 MiB | 7.09 MiB | 1.03 MiB |
379d7a8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
6325c3b | 5.94 MiB | 6.96 MiB | 1.02 MiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a510d1d | 1277.04 ms | 1291.57 ms | 14.53 ms |
21d4150 | 1252.86 ms | 1280.55 ms | 27.69 ms |
6957bfd | 1283.80 ms | 1289.00 ms | 5.20 ms |
eecbbca | 1264.90 ms | 1286.33 ms | 21.43 ms |
379d7a8 | 1267.65 ms | 1288.39 ms | 20.74 ms |
453e1bc | 1294.78 ms | 1308.10 ms | 13.33 ms |
b47809a | 1252.61 ms | 1278.57 ms | 25.96 ms |
49a149b | 1296.47 ms | 1320.20 ms | 23.73 ms |
d301b11 | 1260.61 ms | 1272.06 ms | 11.45 ms |
08a7b4f | 1277.10 ms | 1303.37 ms | 26.27 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a510d1d | 8.16 MiB | 9.17 MiB | 1.01 MiB |
21d4150 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
6957bfd | 8.15 MiB | 9.15 MiB | 1020.71 KiB |
eecbbca | 8.15 MiB | 9.10 MiB | 965.26 KiB |
379d7a8 | 8.16 MiB | 9.16 MiB | 1.00 MiB |
453e1bc | 8.16 MiB | 9.16 MiB | 1.00 MiB |
b47809a | 8.16 MiB | 9.17 MiB | 1.01 MiB |
49a149b | 8.15 MiB | 9.12 MiB | 986.26 KiB |
d301b11 | 8.10 MiB | 9.07 MiB | 1000.82 KiB |
08a7b4f | 8.16 MiB | 9.16 MiB | 1.01 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @brustolin
📜 Description
Changed podspec
EXCLUDED_ARCHS
value to allow podfiles to add more excluded architetures during setup.💡 Motivation and Context
close #1300
💚 How did you test it?
With samples
📝 Checklist
sendDefaultPii
is enabled