Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt DioErrorExtractor to new DioStackTraceExtractor usage #1344

Merged

Conversation

kuhnroyal
Copy link
Contributor

📜 Description

This change now respects the new DioStackTraceExtractor and no longer extracts DioErrpr.stackTrace via DioErrorExtractor

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

CC @ueman @marandaneto

@marandaneto marandaneto enabled auto-merge (squash) March 20, 2023 10:27
@marandaneto
Copy link
Contributor

Thanks @kuhnroyal

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (40680d3) 89.67% compared to head (3ea0d76) 89.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1344      +/-   ##
==========================================
- Coverage   89.67%   89.66%   -0.01%     
==========================================
  Files          59       59              
  Lines        1995     1994       -1     
==========================================
- Hits         1789     1788       -1     
  Misses        206      206              
Impacted Files Coverage Δ
dio/lib/src/dio_error_extractor.dart 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto marandaneto merged commit 8c832a0 into getsentry:main Mar 20, 2023
@kuhnroyal kuhnroyal deleted the feature/improve-dio-error-extractor branch March 27, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants