-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove breadcrumbs from transaction to avoid duplication #1366
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1366 +/- ##
==========================================
+ Coverage 89.79% 89.90% +0.11%
==========================================
Files 59 179 +120
Lines 2018 5758 +3740
==========================================
+ Hits 1812 5177 +3365
- Misses 206 581 +375
... and 119 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2f8f173 | 323.31 ms | 373.29 ms | 49.97 ms |
ef31c7f | 311.39 ms | 359.33 ms | 47.94 ms |
a49594a | 282.27 ms | 344.84 ms | 62.57 ms |
ecb4003 | 332.58 ms | 385.15 ms | 52.57 ms |
8a7f528 | 290.27 ms | 341.80 ms | 51.53 ms |
e893df5 | 310.60 ms | 380.58 ms | 69.98 ms |
56810ff | 309.72 ms | 352.26 ms | 42.54 ms |
379d7a8 | 327.10 ms | 355.39 ms | 28.29 ms |
90db9ff | 334.86 ms | 388.14 ms | 53.28 ms |
cdf7172 | 348.54 ms | 390.81 ms | 42.27 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2f8f173 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
ef31c7f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
a49594a | 5.94 MiB | 6.95 MiB | 1.01 MiB |
ecb4003 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
8a7f528 | 6.06 MiB | 7.03 MiB | 989.36 KiB |
e893df5 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
56810ff | 5.94 MiB | 6.92 MiB | 1001.71 KiB |
379d7a8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
90db9ff | 6.06 MiB | 7.10 MiB | 1.04 MiB |
cdf7172 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a49594a | 1284.83 ms | 1313.29 ms | 28.45 ms |
6957bfd | 1283.80 ms | 1289.00 ms | 5.20 ms |
3f23617 | 1261.93 ms | 1286.10 ms | 24.17 ms |
21845e2 | 1279.37 ms | 1298.81 ms | 19.45 ms |
873fb42 | 1261.00 ms | 1285.92 ms | 24.92 ms |
613760b | 1263.10 ms | 1277.27 ms | 14.16 ms |
49a149b | 1296.47 ms | 1320.20 ms | 23.73 ms |
aed5947 | 1268.67 ms | 1281.10 ms | 12.43 ms |
ebfead1 | 1271.57 ms | 1284.48 ms | 12.91 ms |
08a7b4f | 1277.10 ms | 1303.37 ms | 26.27 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a49594a | 8.16 MiB | 9.16 MiB | 1.00 MiB |
6957bfd | 8.15 MiB | 9.15 MiB | 1020.71 KiB |
3f23617 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
21845e2 | 8.15 MiB | 9.12 MiB | 991.34 KiB |
873fb42 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
613760b | 8.15 MiB | 9.13 MiB | 1000.46 KiB |
49a149b | 8.15 MiB | 9.12 MiB | 986.26 KiB |
aed5947 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
ebfead1 | 8.10 MiB | 9.16 MiB | 1.07 MiB |
08a7b4f | 8.16 MiB | 9.16 MiB | 1.01 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @denrase
📜 Description
Removes breadcrumbs from transaction for android when scope sync is enabled.
💡 Motivation and Context
Closes #1353
💚 How did you test it?
Tests & ran sample app
📝 Checklist
sendDefaultPii
is enabled