-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): Add event.origin
and event.environment
on unhandled exception on iOS
#1419
Conversation
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ae02632 | 309.16 ms | 348.98 ms | 39.82 ms |
b2cbbc8 | 347.80 ms | 395.31 ms | 47.51 ms |
521cfbf | 332.78 ms | 376.04 ms | 43.26 ms |
f96ca24 | 316.08 ms | 388.22 ms | 72.14 ms |
0ac1eed | 370.60 ms | 441.54 ms | 70.94 ms |
9c5aec6 | 287.33 ms | 320.94 ms | 33.61 ms |
a49594a | 282.27 ms | 344.84 ms | 62.57 ms |
21845e2 | 345.08 ms | 382.82 ms | 37.74 ms |
379d7a8 | 327.10 ms | 355.39 ms | 28.29 ms |
fdac48a | 329.50 ms | 396.46 ms | 66.96 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ae02632 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
b2cbbc8 | 6.06 MiB | 7.03 MiB | 995.45 KiB |
521cfbf | 5.94 MiB | 6.97 MiB | 1.03 MiB |
f96ca24 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
0ac1eed | 6.06 MiB | 7.03 MiB | 990.44 KiB |
9c5aec6 | 5.94 MiB | 6.92 MiB | 1001.61 KiB |
a49594a | 5.94 MiB | 6.95 MiB | 1.01 MiB |
21845e2 | 5.94 MiB | 6.92 MiB | 1003.77 KiB |
379d7a8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
fdac48a | 6.06 MiB | 7.09 MiB | 1.03 MiB |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1419 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 181 181
Lines 5794 5794
=======================================
Hits 5229 5229
Misses 565 565 ☔ View full report in Codecov by Sentry. |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6d7a391 | 1265.65 ms | 1289.98 ms | 24.33 ms |
873fb42 | 1261.00 ms | 1285.92 ms | 24.92 ms |
ed605cc | 1246.06 ms | 1262.04 ms | 15.98 ms |
134c9f8 | 1284.48 ms | 1306.18 ms | 21.70 ms |
3637a22 | 1290.39 ms | 1318.42 ms | 28.03 ms |
49a149b | 1296.47 ms | 1320.20 ms | 23.73 ms |
5603ab2 | 1268.47 ms | 1280.73 ms | 12.26 ms |
b728df4 | 1287.43 ms | 1293.94 ms | 6.51 ms |
e893df5 | 1247.90 ms | 1262.31 ms | 14.41 ms |
aa950e9 | 1275.17 ms | 1295.33 ms | 20.16 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6d7a391 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
873fb42 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
ed605cc | 8.10 MiB | 9.17 MiB | 1.08 MiB |
134c9f8 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
3637a22 | 8.09 MiB | 9.07 MiB | 1001.02 KiB |
49a149b | 8.15 MiB | 9.12 MiB | 986.26 KiB |
5603ab2 | 8.15 MiB | 9.12 MiB | 990.57 KiB |
b728df4 | 8.15 MiB | 9.15 MiB | 1020.72 KiB |
e893df5 | 8.09 MiB | 9.07 MiB | 1001.04 KiB |
aa950e9 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
@krystofwoldrich good catch, thanks |
Probably Android has the same issue, would you like to fix it? Check the |
To check, maybe |
Thanks, I will check it. |
Native needed a change too. |
📜 Description
Because of the naming change of the native clients, the
event.origin
andevent.environment
tags were missing on unhandled exceptions issues.💚 How did you test it?
example flutter app
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps