-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if the Native SDKs are enabled when using autoInitializeNativeSdk false #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
May 26, 2023
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Show resolved
Hide resolved
@krystofwoldrich this might be useful for RN as well. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1489 +/- ##
=======================================
Coverage 90.18% 90.18%
=======================================
Files 181 181
Lines 5776 5776
=======================================
Hits 5209 5209
Misses 567 567 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
457a85b | 312.37 ms | 376.67 ms | 64.31 ms |
1c6eb5b | 350.69 ms | 393.86 ms | 43.17 ms |
8a7f528 | 290.27 ms | 341.80 ms | 51.53 ms |
abcdba3 | 354.68 ms | 399.04 ms | 44.36 ms |
a609134 | 350.12 ms | 404.12 ms | 54.00 ms |
62dde43 | 339.21 ms | 423.06 ms | 83.85 ms |
0db91cc | 327.85 ms | 387.31 ms | 59.46 ms |
559d28f | 302.35 ms | 339.53 ms | 37.18 ms |
0a82a1e | 321.02 ms | 393.82 ms | 72.80 ms |
fe4aa56 | 356.06 ms | 428.67 ms | 72.61 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
457a85b | 6.06 MiB | 7.09 MiB | 1.03 MiB |
1c6eb5b | 5.94 MiB | 6.92 MiB | 1001.53 KiB |
8a7f528 | 6.06 MiB | 7.03 MiB | 989.36 KiB |
abcdba3 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
a609134 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
62dde43 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
0db91cc | 5.94 MiB | 6.95 MiB | 1.01 MiB |
559d28f | 5.94 MiB | 6.92 MiB | 1001.70 KiB |
0a82a1e | 6.15 MiB | 7.11 MiB | 981.82 KiB |
fe4aa56 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8e133ad | 1268.19 ms | 1277.37 ms | 9.18 ms |
aed5947 | 1268.67 ms | 1281.10 ms | 12.43 ms |
e893df5 | 1247.90 ms | 1262.31 ms | 14.41 ms |
40680d3 | 1243.22 ms | 1257.02 ms | 13.80 ms |
3a43905 | 1254.31 ms | 1266.35 ms | 12.04 ms |
ef2f368 | 1259.12 ms | 1277.04 ms | 17.92 ms |
8ced2dc | 1258.35 ms | 1272.98 ms | 14.62 ms |
3a69405 | 1292.84 ms | 1303.96 ms | 11.12 ms |
dd1f7d2 | 1263.16 ms | 1275.15 ms | 11.99 ms |
519423f | 1240.80 ms | 1260.88 ms | 20.08 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8e133ad | 8.10 MiB | 9.16 MiB | 1.07 MiB |
aed5947 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
e893df5 | 8.09 MiB | 9.07 MiB | 1001.04 KiB |
40680d3 | 8.10 MiB | 9.16 MiB | 1.07 MiB |
3a43905 | 8.10 MiB | 9.18 MiB | 1.08 MiB |
ef2f368 | 8.15 MiB | 9.10 MiB | 965.24 KiB |
8ced2dc | 8.10 MiB | 9.16 MiB | 1.07 MiB |
3a69405 | 8.15 MiB | 9.15 MiB | 1018.56 KiB |
dd1f7d2 | 8.10 MiB | 9.16 MiB | 1.07 MiB |
519423f | 8.10 MiB | 9.16 MiB | 1.06 MiB |
marandaneto
requested review from
krystofwoldrich and
stefanosiano
as code owners
May 26, 2023 08:44
stefanosiano
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Check if the Native SDKs are enabled when using
autoInitializeNativeSdk=false
💡 Motivation and Context
Relates to #1486
💚 How did you test it?
Running autoInitializeNativeSdk mode and checking logs.
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps