packages upgraded #1947

hasanm08 · 2024-03-24T09:14:02Z

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
I updated the docs if needed
All tests passing
No breaking changes

🔮 Next steps

mishkov · 2024-03-25T09:25:21Z

Important PR to me because I cannot use latest version of other packages due to sentry_flutter. So for now I am just gonna depend on this PR

kuhnroyal · 2024-03-25T10:05:27Z

Sadly this is not how package updates work for well adapted and used packages.

hasanm08 · 2024-03-26T14:24:05Z

Sadly this is not how package updates work for well adapted and used packages.

how should I upgrade them when no breaking change happened?

kuhnroyal · 2024-03-26T14:56:25Z

You can locally always run pub upgrade.
For major releases you can override them if there is no breaking change until the sentry package supports the new version.
But sentry supports several versions back and older Dart SDKs so an update should always try to increase the version range and not force the new major version on everyone.
See #1948

hasanm08 · 2024-03-27T11:28:43Z

You can locally always run pub upgrade. For major releases you can override them if there is no breaking change until the sentry package supports the new version. But sentry supports several versions back and older Dart SDKs so an update should always try to increase the version range and not force the new major version on everyone. See #1948

but it forced package_info_plus version before and I can not use it in my project because I needed package_info_plus latest version to solve the gradle 8.0 issues that is needed in flutter 3.19

kuhnroyal · 2024-03-27T11:38:51Z

#1948 was merged, you can check how it was solved.
You can locally use something like this:

dependency_overrides:
  package_info_plus: 7.0.0

hasanm08 · 2024-04-02T07:22:16Z

#1948 was merged, you can check how it was solved. You can locally use something like this:
dependency_overrides:
  package_info_plus: 7.0.0

issue fixed recheck please

kahest · 2024-04-08T13:53:13Z

@hasanm08 we merged the required change for package_info_plus in #1948, the release for this is incoming. Thanks for opening this PR and apologies that this went under our radar - in future, please feel free to ping me to get attention on your issues/PRs.
@buenaflor please take a look if the other changes make sense

codecov · 2024-04-08T14:01:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.57%. Comparing base (1ac008b) to head (98fcbb0).
Report is 117 commits behind head on main.

❗ Current head 98fcbb0 differs from pull request most recent head ff504ea

Please upload reports for the commit ff504ea to get more accurate results.

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #1947    +/-   ##
========================================
  Coverage   88.57%   88.57%            
========================================
  Files         207      213     +6     
  Lines        6897     7110   +213     
========================================
+ Hits         6109     6298   +189     
- Misses        788      812    +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

buenaflor

generally looks okay to me but as far as I can see most of the changes here are applied to examples so they don't really have an impact on the SDK itself.

have you encountered any issues here when running the samples or any specific reason you chose these packages to change the dep ranges? @hasanm08

hasanm08 · 2024-04-08T14:15:30Z

@hasanm08 we merged the required change for package_info_plus in #1948, the release for this is incoming. Thanks for opening this PR and apologies that this went under our radar - in future, please feel free to ping me to get attention on your issues/PRs.
@buenaflor please take a look if the other changes make sense

My forked branch is uptodate with your branch but still some packages had issue
And still packageInfoPlus needed to be upgraded in sentry_flutter
And this issue distracts my work
Please recheck and merge it

hasanm08 · 2024-04-08T14:20:21Z

generally looks okay to me but as far as I can see most of the changes here are either dev dependencies, or applied to examples so they don't really have an impact on the SDK itself.

have you encountered any issues here when running the samples or any specific reason you chose these packages to change the dep ranges? @hasanm08

I have issues using sentry_flutter (latest)and wakelock_plus (latest)
Together because of the packages version in the latest package of yours
Nevermind if you don't merge my work, but please fix this issue and publish a new version

buenaflor · 2024-04-08T14:51:14Z

@hasanm08 the only change that you did here that might affect you directly must be the hive pubspec.yaml which adds a lint range is that correct?

I'm not against merging this but I wanna get the context behind it first

I have issues using sentry_flutter (latest)and wakelock_plus (latest)
Together because of the packages version in the latest package of yours

We already know that package_info_plus is causing issues and are releasing a fix for it soon.
Ideally you can provide other errors here you are encountering so we know which dependencies exactly are the problem.

buenaflor · 2024-04-10T08:15:15Z

just an fyi, the fix for package info is out as of 7.19.0 @hasanm08

buenaflor · 2024-04-12T08:49:47Z

@hasanm08 do you still need these changes?

hasanm08 · 2024-04-12T15:38:25Z

@hasanm08 do you still need these changes?

Yes please merge it to use latest version

hasanm08 · 2024-04-12T15:38:56Z

just an fyi, the fix for package info is out as of 7.19.0 @hasanm08

Fixed

hasanm08 · 2024-04-21T09:40:28Z

@mishkov

buenaflor · 2024-04-22T15:54:42Z

Ideally you can provide other errors here you are encountering so we know which dependencies exactly are the problem.

Can you provide errors that happen without this PR?

hasanm08 · 2024-04-23T05:43:09Z

Ideally you can provide other errors here you are encountering so we know which dependencies exactly are the problem.

Can you provide errors that happen without this PR?

package info plus versioning latest is 8.0.0
please merge it to fix

vaind · 2024-04-23T11:35:04Z

min_version_test/pubspec.yaml

@@ -18,7 +18,7 @@ publish_to: 'none' # Remove this line if you wish to publish to pub.dev
 version: 1.0.0+1

 environment:
-  sdk: '2.17.0'
+  sdk: '>=2.17.1 <4.0.0'


The min_version_test project is specifically created to test against the lowest supported SDK version (2.17.0), so this change doesn't seem right. Why is it necessary?

buenaflor · 2024-05-28T11:15:00Z

package info plus versioning latest is 8.0.0

this is already fixed, I don't think we need this pr anymore

buenaflor · 2024-06-07T08:47:24Z

Closing this pr as the problems mentioned have already been fixed.

Feel free to ping me if there is anything else

packages upgraded

f19c2a1

hasanm08 requested review from krystofwoldrich, stefanosiano and buenaflor as code owners March 24, 2024 09:14

hasanm08 added 2 commits April 2, 2024 10:39

Merge branch 'main' of https://github.com/getsentry/sentry-dart

5a5bf4f

enhance packages versioning

5bfca7d

hasanm08 and others added 2 commits April 2, 2024 10:54

enhance packages versioning

ca5efc0

Merge branch 'main' into main

98fcbb0

This comment was marked as spam.

Sign in to view

buenaflor reviewed Apr 8, 2024

View reviewed changes

buenaflor marked this pull request as draft April 11, 2024 08:29

hasanm08 added 2 commits April 12, 2024 19:02

package_info_plus upgraded

b69c78c

Merge branch 'main' of https://github.com/hasanm08/sentry-dart

165a187

Merge branch 'main' into main

4c3c807

hasanm08 marked this pull request as ready for review April 21, 2024 09:42

hasanm08 added 2 commits April 23, 2024 09:10

package info plus version 8 added

b513576

Merge branch 'main' of https://github.com/hasanm08/sentry-dart

40d2220

vaind reviewed Apr 23, 2024

View reviewed changes

sdk version enhanced

ff504ea

buenaflor closed this Jun 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

packages upgraded #1947

packages upgraded #1947

hasanm08 commented Mar 24, 2024 •

edited

Loading

mishkov commented Mar 25, 2024 •

edited

Loading

kuhnroyal commented Mar 25, 2024

hasanm08 commented Mar 26, 2024

kuhnroyal commented Mar 26, 2024

hasanm08 commented Mar 27, 2024 •

edited

Loading

kuhnroyal commented Mar 27, 2024

hasanm08 commented Apr 2, 2024

This comment was marked as spam.

kahest commented Apr 8, 2024

codecov bot commented Apr 8, 2024 •

edited

Loading

buenaflor left a comment •

edited

Loading

hasanm08 commented Apr 8, 2024

hasanm08 commented Apr 8, 2024 •

edited

Loading

buenaflor commented Apr 8, 2024 •

edited

Loading

buenaflor commented Apr 10, 2024

buenaflor commented Apr 12, 2024

hasanm08 commented Apr 12, 2024

hasanm08 commented Apr 12, 2024

hasanm08 commented Apr 21, 2024

buenaflor commented Apr 22, 2024

hasanm08 commented Apr 23, 2024

vaind Apr 23, 2024

hasanm08 May 28, 2024

buenaflor commented May 28, 2024

buenaflor commented Jun 7, 2024

packages upgraded #1947

packages upgraded #1947

Conversation

hasanm08 commented Mar 24, 2024 • edited Loading

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

mishkov commented Mar 25, 2024 • edited Loading

kuhnroyal commented Mar 25, 2024

hasanm08 commented Mar 26, 2024

kuhnroyal commented Mar 26, 2024

hasanm08 commented Mar 27, 2024 • edited Loading

kuhnroyal commented Mar 27, 2024

hasanm08 commented Apr 2, 2024

This comment was marked as spam.

kahest commented Apr 8, 2024

codecov bot commented Apr 8, 2024 • edited Loading

Codecov Report

buenaflor left a comment • edited Loading

Choose a reason for hiding this comment

hasanm08 commented Apr 8, 2024

hasanm08 commented Apr 8, 2024 • edited Loading

buenaflor commented Apr 8, 2024 • edited Loading

buenaflor commented Apr 10, 2024

buenaflor commented Apr 12, 2024

hasanm08 commented Apr 12, 2024

hasanm08 commented Apr 12, 2024

hasanm08 commented Apr 21, 2024

buenaflor commented Apr 22, 2024

hasanm08 commented Apr 23, 2024

vaind Apr 23, 2024

Choose a reason for hiding this comment

hasanm08 May 28, 2024

Choose a reason for hiding this comment

buenaflor commented May 28, 2024

buenaflor commented Jun 7, 2024

hasanm08 commented Mar 24, 2024 •

edited

Loading

mishkov commented Mar 25, 2024 •

edited

Loading

hasanm08 commented Mar 27, 2024 •

edited

Loading

codecov bot commented Apr 8, 2024 •

edited

Loading

buenaflor left a comment •

edited

Loading

hasanm08 commented Apr 8, 2024 •

edited

Loading

buenaflor commented Apr 8, 2024 •

edited

Loading