Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump package_info_plus #1948

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Bump package_info_plus #1948

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0183bd
bump pakcage info plus
denrase Mar 25, 2024
5843cb7
Support version < 7
denrase Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flutter/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ dependencies:
flutter_web_plugins:
sdk: flutter
sentry: 7.18.0
package_info_plus: '>=1.0.0 <=5.0.1'
package_info_plus: '>=1.0.0 <=6.0.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be the following since there's already v6?

Suggested change
package_info_plus: '>=1.0.0 <=6.0.0'
package_info_plus: '>=1.0.0 <=7.0.0'

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.0.0 does not exist and might contain breaking changes once released. We could probably go with <7.0.0 if we assume 6.x version will not have breaking changes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, you're right. <7.0.0 is what I meant

meta: ^1.3.0
ffi: ^2.0.0

Expand Down
Loading