Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set snapshot to true #2000

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Set snapshot to true #2000

merged 6 commits into from
Apr 24, 2024

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented Apr 19, 2024

📜 Description

Fixes #1879

💡 Motivation and Context

💚 How did you test it?

Manually & new test

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Where am I now supposed to put the changelog?

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.57%. Comparing base (1ac008b) to head (5f2bab4).
Report is 84 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2000      +/-   ##
==========================================
- Coverage   88.57%   87.57%   -1.00%     
==========================================
  Files         207      154      -53     
  Lines        6897     4998    -1899     
==========================================
- Hits         6109     4377    -1732     
+ Misses        788      621     -167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ueman
Copy link
Collaborator Author

ueman commented Apr 23, 2024

The test failure is due to a cancellation. I unfortunately can't rerun it tho. I think other than that this should be good to go

@buenaflor
Copy link
Contributor

yeah, the macos runner is pretty slow and times out after 30mins

@buenaflor buenaflor merged commit 47dd159 into getsentry:main Apr 24, 2024
106 of 114 checks passed
@ueman ueman deleted the snapshot-equals-true branch April 24, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set snapshot to true for errors for v8
2 participants