Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APS to sample #2008

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Add APS to sample #2008

merged 1 commit into from
Apr 24, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Apr 23, 2024

Fixes warning emails about APS that are generated when a new testflight build is uploaded

#skip-changelog

Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1249.35 ms 1273.81 ms 24.46 ms
Size 8.32 MiB 9.40 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a775d3f 1241.29 ms 1241.53 ms 0.24 ms
04db237 1273.29 ms 1306.50 ms 33.21 ms
d0312c9 1205.55 ms 1224.45 ms 18.90 ms
e964e2b 1203.50 ms 1223.16 ms 19.66 ms
f83bc1d 1247.12 ms 1249.78 ms 2.65 ms
4ad2751 1247.67 ms 1249.20 ms 1.53 ms
8e133ad 1268.19 ms 1277.37 ms 9.18 ms
464b4d0 1249.02 ms 1261.22 ms 12.20 ms
bd1b990 1209.43 ms 1226.96 ms 17.53 ms
b98109e 1254.19 ms 1279.90 ms 25.71 ms

App size

Revision Plain With Sentry Diff
a775d3f 8.28 MiB 9.34 MiB 1.06 MiB
04db237 8.15 MiB 9.13 MiB 1003.16 KiB
d0312c9 8.32 MiB 9.39 MiB 1.06 MiB
e964e2b 8.32 MiB 9.38 MiB 1.06 MiB
f83bc1d 8.28 MiB 9.34 MiB 1.05 MiB
4ad2751 8.29 MiB 9.39 MiB 1.10 MiB
8e133ad 8.10 MiB 9.16 MiB 1.07 MiB
464b4d0 8.10 MiB 9.16 MiB 1.07 MiB
bd1b990 8.32 MiB 9.38 MiB 1.06 MiB
b98109e 8.10 MiB 9.17 MiB 1.08 MiB

Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 356.63 ms 418.89 ms 62.26 ms
Size 6.33 MiB 7.30 MiB 987.48 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
464b4d0 320.71 ms 380.02 ms 59.31 ms
21845e2 345.08 ms 382.82 ms 37.74 ms
3f3ef0b 382.24 ms 459.26 ms 77.02 ms
f9d18f3 430.94 ms 497.59 ms 66.65 ms
72dfc83 298.62 ms 340.14 ms 41.52 ms
6aab859 306.27 ms 377.92 ms 71.65 ms
6034b0a 406.35 ms 475.93 ms 69.59 ms
24b6e60 440.64 ms 557.96 ms 117.32 ms
2f8f173 323.31 ms 373.29 ms 49.97 ms
4c78360 402.29 ms 462.04 ms 59.76 ms

App size

Revision Plain With Sentry Diff
464b4d0 6.06 MiB 7.03 MiB 990.27 KiB
21845e2 5.94 MiB 6.92 MiB 1003.77 KiB
3f3ef0b 6.33 MiB 7.26 MiB 943.11 KiB
f9d18f3 6.15 MiB 7.13 MiB 1000.49 KiB
72dfc83 5.94 MiB 6.92 MiB 1001.71 KiB
6aab859 6.15 MiB 7.13 MiB 999.97 KiB
6034b0a 6.34 MiB 7.29 MiB 970.36 KiB
24b6e60 6.33 MiB 7.26 MiB 950.14 KiB
2f8f173 5.94 MiB 6.95 MiB 1.01 MiB
4c78360 6.33 MiB 7.27 MiB 954.08 KiB

@buenaflor buenaflor merged commit cfa25fc into main Apr 24, 2024
46 checks passed
@buenaflor buenaflor deleted the fix/aps-apple-env branch April 24, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants