Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate: user segment #2119

Merged
merged 5 commits into from
Jun 25, 2024
Merged

deprecate: user segment #2119

merged 5 commits into from
Jun 25, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jun 20, 2024

📜 Description

Functionality for user segment has been removed from sentry and can now be deprecated in the SDKs

💡 Motivation and Context

Closes #2115

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.64%. Comparing base (7e7f0b1) to head (6cb8f46).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2119   +/-   ##
=======================================
  Coverage   88.64%   88.64%           
=======================================
  Files         223      223           
  Lines        7583     7583           
=======================================
  Hits         6722     6722           
  Misses        861      861           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor force-pushed the feat/deprecate-user-segment branch from 594224f to 3d9c9a0 Compare June 20, 2024 12:44
@buenaflor buenaflor marked this pull request as ready for review June 20, 2024 12:47
Copy link
Contributor

github-actions bot commented Jun 20, 2024

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 406.94 ms 488.52 ms 81.58 ms
Size 6.35 MiB 7.34 MiB 1008.34 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f275487 369.08 ms 432.44 ms 63.36 ms
8776cdf 353.32 ms 416.58 ms 63.26 ms
42f6e7e 308.71 ms 360.06 ms 51.35 ms
04db237 330.16 ms 428.38 ms 98.22 ms
1c6eb5b 350.69 ms 393.86 ms 43.17 ms
ccc09e4 308.21 ms 357.74 ms 49.54 ms
e5b744f 302.70 ms 342.17 ms 39.47 ms
43abc4f 406.54 ms 475.53 ms 68.99 ms
64e4616 349.82 ms 436.96 ms 87.14 ms
56810ff 309.72 ms 352.26 ms 42.54 ms

App size

Revision Plain With Sentry Diff
f275487 6.33 MiB 7.26 MiB 947.03 KiB
8776cdf 6.34 MiB 7.28 MiB 966.66 KiB
42f6e7e 6.27 MiB 7.20 MiB 956.06 KiB
04db237 5.94 MiB 6.95 MiB 1.01 MiB
1c6eb5b 5.94 MiB 6.92 MiB 1001.53 KiB
ccc09e4 5.94 MiB 6.95 MiB 1.01 MiB
e5b744f 6.06 MiB 7.09 MiB 1.03 MiB
43abc4f 6.35 MiB 7.34 MiB 1007.72 KiB
64e4616 6.27 MiB 7.20 MiB 956.52 KiB
56810ff 5.94 MiB 6.92 MiB 1001.71 KiB

Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.43 ms 1230.51 ms 13.08 ms
Size 8.33 MiB 9.61 MiB 1.27 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a609134 1254.50 ms 1265.08 ms 10.58 ms
ddc97ad 1228.02 ms 1232.61 ms 4.59 ms
9fe67d5 1242.33 ms 1268.77 ms 26.44 ms
95d0636 1243.73 ms 1245.54 ms 1.81 ms
bd37365 1236.22 ms 1243.27 ms 7.04 ms
b0811cc 1238.23 ms 1255.82 ms 17.59 ms
689d2fd 1257.71 ms 1265.16 ms 7.45 ms
3334ac1 1259.22 ms 1275.40 ms 16.17 ms
4efee31 1270.33 ms 1285.75 ms 15.42 ms
ae02632 1286.77 ms 1300.37 ms 13.60 ms

App size

Revision Plain With Sentry Diff
a609134 8.16 MiB 9.16 MiB 1.01 MiB
ddc97ad 8.29 MiB 9.37 MiB 1.08 MiB
9fe67d5 8.32 MiB 9.50 MiB 1.18 MiB
95d0636 8.29 MiB 9.38 MiB 1.09 MiB
bd37365 8.28 MiB 9.34 MiB 1.06 MiB
b0811cc 8.32 MiB 9.38 MiB 1.06 MiB
689d2fd 8.10 MiB 9.16 MiB 1.06 MiB
3334ac1 8.10 MiB 9.17 MiB 1.08 MiB
4efee31 8.15 MiB 9.12 MiB 991.35 KiB
ae02632 8.16 MiB 9.15 MiB 1020.68 KiB

@buenaflor buenaflor merged commit e4d5aa8 into main Jun 25, 2024
132 checks passed
@buenaflor buenaflor deleted the feat/deprecate-user-segment branch June 25, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate and remove user segment
2 participants