Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add memory usage to contexts #2133
Add memory usage to contexts #2133
Changes from 4 commits
cf5df45
eeb797f
7c05a02
d3302e8
b210da5
37ea59c
d10dbbe
6088536
89657ee
ba8a048
e8d8880
fcbcade
eae3175
e2d07f0
1ab1f7e
f880f63
ce54ed1
3a2ce0a
c1d87f6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add currentRss to app_memory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does
currentRss
compare to what the native side sets? Does it override what the native side sets?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the code and we only set these values if there are no native SDKs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think android sets it, I know iOS for sure does @denrase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated so we set
appMemory
toProcessInfo.currentRss
, it it's not already set, regardless of native integration. The other values are merged, so this is additional information.On Linux/Windows we now also add free and total system memory, if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there any alternatives for web?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found this, but there's not much documentation: https://api.dart.dev/stable/2.18.0/dart-html/MemoryInfo/usedJSHeapSize.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is based on this https://developer.mozilla.org/en-US/docs/Web/API/Performance/memory
it's deprecated and not all browsers support it, dunno if it's worth the effort to add this if we have to remove it again at some point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, i removed it after reading the docs and added some info.
Check warning on line 149 in dart/lib/src/event_processor/enricher/io_enricher_event_processor.dart
Codecov / codecov/patch
dart/lib/src/event_processor/enricher/io_enricher_event_processor.dart#L149