Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: temporarily disable sentry-native Windows integration #2363

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Oct 16, 2024

📜 Description

Adding sentry-native to the build currently breaks symbol upload via sentry_dart_plugin so we need to disable it for now until the plugin is fixed.

💡 Motivation and Context

getsentry/sentry-dart-plugin#270

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.76%. Comparing base (b930b94) to head (dba2e9d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2363      +/-   ##
==========================================
- Coverage   84.82%   84.76%   -0.07%     
==========================================
  Files         253      253              
  Lines        9062     9059       -3     
==========================================
- Hits         7687     7679       -8     
- Misses       1375     1380       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaind
Copy link
Collaborator Author

vaind commented Oct 16, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

What do we do about the changelog, considering a it was already part of the beta release but not stable?

Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 514.61 ms 551.81 ms 37.20 ms
Size 6.49 MiB 7.57 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0bed04d 382.15 ms 458.33 ms 76.18 ms
905bf99 459.73 ms 505.26 ms 45.53 ms
2966d88 365.71 ms 422.50 ms 56.79 ms
379d7a8 327.10 ms 355.39 ms 28.29 ms
d5f600b 392.88 ms 466.73 ms 73.85 ms
ed2ae08 360.06 ms 440.92 ms 80.86 ms
6957bfd 325.88 ms 380.30 ms 54.43 ms
8da6ae0 526.18 ms 596.82 ms 70.64 ms
4b29d6e 386.80 ms 430.86 ms 44.06 ms
8932ece 309.56 ms 377.28 ms 67.72 ms

App size

Revision Plain With Sentry Diff
0bed04d 6.33 MiB 7.30 MiB 987.71 KiB
905bf99 6.49 MiB 7.56 MiB 1.07 MiB
2966d88 6.33 MiB 7.27 MiB 954.11 KiB
379d7a8 5.94 MiB 6.95 MiB 1.01 MiB
d5f600b 6.33 MiB 7.26 MiB 943.41 KiB
ed2ae08 6.27 MiB 7.20 MiB 958.73 KiB
6957bfd 5.94 MiB 6.95 MiB 1.01 MiB
8da6ae0 6.49 MiB 7.57 MiB 1.08 MiB
4b29d6e 6.33 MiB 7.26 MiB 946.14 KiB
8932ece 6.16 MiB 7.13 MiB 1000.89 KiB

Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1257.02 ms 1281.41 ms 24.39 ms
Size 8.38 MiB 9.75 MiB 1.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d089990 1206.19 ms 1233.08 ms 26.89 ms
62dde43 1258.43 ms 1276.81 ms 18.38 ms
78eeed5 1259.33 ms 1270.14 ms 10.82 ms
72eeb80 1236.06 ms 1254.86 ms 18.80 ms
ea60f10 1243.89 ms 1270.83 ms 26.94 ms
8fa3934 1252.79 ms 1272.41 ms 19.62 ms
0ceb89c 1252.02 ms 1271.78 ms 19.75 ms
c70e01a 1273.00 ms 1299.12 ms 26.12 ms
ed2ae08 1222.10 ms 1226.57 ms 4.47 ms
dd76eef 1222.51 ms 1258.38 ms 35.87 ms

App size

Revision Plain With Sentry Diff
d089990 8.33 MiB 9.40 MiB 1.07 MiB
62dde43 8.16 MiB 9.17 MiB 1.01 MiB
78eeed5 8.29 MiB 9.38 MiB 1.09 MiB
72eeb80 8.34 MiB 9.65 MiB 1.31 MiB
ea60f10 8.38 MiB 9.73 MiB 1.36 MiB
8fa3934 8.09 MiB 9.07 MiB 1000.86 KiB
0ceb89c 8.15 MiB 9.12 MiB 989.78 KiB
c70e01a 8.16 MiB 9.17 MiB 1.01 MiB
ed2ae08 8.28 MiB 9.34 MiB 1.06 MiB
dd76eef 8.33 MiB 9.64 MiB 1.31 MiB

@vaind vaind marked this pull request as ready for review October 16, 2024 11:10
@vaind vaind merged commit 752e1cb into main Oct 16, 2024
131 of 133 checks passed
@vaind vaind deleted the chore/disable-sentry-native branch October 16, 2024 11:14
vaind added a commit that referenced this pull request Nov 21, 2024
vaind added a commit that referenced this pull request Nov 21, 2024
* Revert "chore: temporarily disable sentry-native Windows integration (#2363)"

This reverts commit 752e1cb.

* update sentry plugin dependency

* chore: update changelog

* roll back sentry-native to v0.7.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants