Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cocoa SDK init after hot-restart #2452

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Nov 26, 2024

📜 Description

Fixes #2412 by letting the CocoaSDK know it should start the session when we init it.

💡 Motivation and Context

See issue description in getsentry/sentry-cocoa#4575

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/ios/Classes/SentryFlutterPluginApple.swift

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (13f8952) to head (04c1779).
Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2452      +/-   ##
==========================================
+ Coverage   86.84%   91.83%   +4.98%     
==========================================
  Files         260       84     -176     
  Lines        9239     2901    -6338     
==========================================
- Hits         8024     2664    -5360     
+ Misses       1215      237     -978     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 500.56 ms 536.94 ms 36.38 ms
Size 6.49 MiB 7.56 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
cdf7172 348.54 ms 390.81 ms 42.27 ms
8ced2dc 295.58 ms 336.49 ms 40.91 ms
74e1fdd 398.61 ms 418.43 ms 19.82 ms
2d4fd8b 376.67 ms 456.88 ms 80.21 ms
0a23f98 377.19 ms 416.18 ms 39.00 ms
0f067d3 359.56 ms 431.28 ms 71.72 ms
d301b11 337.96 ms 395.04 ms 57.08 ms
1c6eb5b 350.69 ms 393.86 ms 43.17 ms
24f71aa 358.49 ms 455.90 ms 97.41 ms
33527b4 403.58 ms 507.44 ms 103.86 ms

App size

Revision Plain With Sentry Diff
cdf7172 5.94 MiB 6.95 MiB 1.01 MiB
8ced2dc 6.06 MiB 7.03 MiB 990.29 KiB
74e1fdd 6.33 MiB 7.27 MiB 954.12 KiB
2d4fd8b 6.27 MiB 7.20 MiB 958.59 KiB
0a23f98 6.06 MiB 7.03 MiB 996.97 KiB
0f067d3 6.33 MiB 7.30 MiB 992.08 KiB
d301b11 6.06 MiB 7.09 MiB 1.03 MiB
1c6eb5b 5.94 MiB 6.92 MiB 1001.53 KiB
24f71aa 6.06 MiB 7.03 MiB 990.30 KiB
33527b4 6.35 MiB 7.42 MiB 1.07 MiB

Previous results on branch: fix/apple-hot-restart-session-management

Startup times

Revision Plain With Sentry Diff
648d448 518.27 ms 595.84 ms 77.57 ms

App size

Revision Plain With Sentry Diff
648d448 6.49 MiB 7.56 MiB 1.08 MiB

Copy link
Contributor

github-actions bot commented Nov 26, 2024

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1239.49 ms 1271.45 ms 31.96 ms
Size 8.38 MiB 9.78 MiB 1.40 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8ced2dc 1258.35 ms 1272.98 ms 14.62 ms
c978477 1228.43 ms 1249.17 ms 20.74 ms
f172c4d 1350.66 ms 1408.49 ms 57.83 ms
6f3717a 1259.84 ms 1280.90 ms 21.06 ms
5d2b46d 1244.31 ms 1245.16 ms 0.86 ms
8e4eeb3 1212.06 ms 1225.29 ms 13.22 ms
ef6466d 1209.88 ms 1225.81 ms 15.93 ms
94757e3 1240.84 ms 1252.24 ms 11.41 ms
689d2fd 1257.71 ms 1265.16 ms 7.45 ms
7f2b01d 1253.92 ms 1266.70 ms 12.78 ms

App size

Revision Plain With Sentry Diff
8ced2dc 8.10 MiB 9.16 MiB 1.07 MiB
c978477 8.32 MiB 9.50 MiB 1.18 MiB
f172c4d 8.33 MiB 9.62 MiB 1.29 MiB
6f3717a 8.33 MiB 9.62 MiB 1.29 MiB
5d2b46d 8.29 MiB 9.36 MiB 1.07 MiB
8e4eeb3 8.32 MiB 9.38 MiB 1.06 MiB
ef6466d 8.33 MiB 9.40 MiB 1.07 MiB
94757e3 8.38 MiB 9.75 MiB 1.37 MiB
689d2fd 8.10 MiB 9.16 MiB 1.06 MiB
7f2b01d 8.16 MiB 9.16 MiB 1.00 MiB

Previous results on branch: fix/apple-hot-restart-session-management

Startup times

Revision Plain With Sentry Diff
648d448 1249.43 ms 1277.53 ms 28.10 ms

App size

Revision Plain With Sentry Diff
648d448 8.38 MiB 9.78 MiB 1.40 MiB

@vaind vaind marked this pull request as ready for review November 27, 2024 08:33
@vaind vaind enabled auto-merge (squash) November 27, 2024 08:43
@vaind vaind merged commit 05933ac into main Nov 27, 2024
52 checks passed
@vaind vaind deleted the fix/apple-hot-restart-session-management branch November 27, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Replay Type Error: "'Null' is not a subtype of type 'String'"
2 participants