Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: check for SentryTracer type in TTID #2497

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Dec 13, 2024

Unlikely to happen normally but it fixes a flaky integration test

@buenaflor buenaflor changed the base branch from main to temp/8.11.1 December 13, 2024 16:34
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (temp/8.11.1@7b4ce83). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             temp/8.11.1    #2497   +/-   ##
==============================================
  Coverage               ?   91.83%           
==============================================
  Files                  ?       84           
  Lines                  ?     2902           
  Branches               ?        0           
==============================================
  Hits                   ?     2665           
  Misses                 ?      237           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor changed the title improvement: check for type before casting improvement: check for SentryTracer type in TTID Dec 13, 2024
@buenaflor buenaflor merged commit a8bff7d into temp/8.11.1 Dec 13, 2024
52 checks passed
@buenaflor buenaflor deleted the chore/fix-flakiness branch December 13, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants