-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS copy native replay screenshot in-memory to native #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
be173fa | 1364.84 ms | 1424.49 ms | 59.65 ms |
24f71aa | 1267.47 ms | 1272.00 ms | 4.53 ms |
7224aae | 1246.78 ms | 1268.35 ms | 21.58 ms |
9f9dd52 | 1364.63 ms | 1394.89 ms | 30.25 ms |
abcdba3 | 1257.31 ms | 1283.49 ms | 26.18 ms |
77db8d4 | 1228.47 ms | 1248.80 ms | 20.33 ms |
905bf99 | 1240.84 ms | 1271.47 ms | 30.63 ms |
cf91c9d | 1217.08 ms | 1233.00 ms | 15.92 ms |
1c6eb5b | 1277.85 ms | 1285.71 ms | 7.86 ms |
13f8952 | 1249.98 ms | 1278.31 ms | 28.33 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
be173fa | 8.33 MiB | 9.54 MiB | 1.22 MiB |
24f71aa | 8.10 MiB | 9.16 MiB | 1.07 MiB |
7224aae | 8.42 MiB | 9.83 MiB | 1.40 MiB |
9f9dd52 | 8.33 MiB | 9.63 MiB | 1.29 MiB |
abcdba3 | 8.15 MiB | 9.12 MiB | 989.76 KiB |
77db8d4 | 8.38 MiB | 9.73 MiB | 1.35 MiB |
905bf99 | 8.38 MiB | 9.74 MiB | 1.36 MiB |
cf91c9d | 8.33 MiB | 9.40 MiB | 1.07 MiB |
1c6eb5b | 8.15 MiB | 9.12 MiB | 986.27 KiB |
13f8952 | 8.38 MiB | 9.78 MiB | 1.40 MiB |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a510d1d | 295.63 ms | 344.65 ms | 49.03 ms |
8fa3934 | 340.64 ms | 407.92 ms | 67.28 ms |
1d47eb7 | 282.26 ms | 342.52 ms | 60.26 ms |
68677de | 364.41 ms | 415.61 ms | 51.20 ms |
0a23f98 | 377.19 ms | 416.18 ms | 39.00 ms |
3de8b9b | 348.55 ms | 445.84 ms | 97.29 ms |
bd75526 | 515.20 ms | 568.79 ms | 53.59 ms |
c1bb00f | 303.77 ms | 371.88 ms | 68.11 ms |
211a7aa | 324.19 ms | 393.26 ms | 69.07 ms |
04211b9 | 502.46 ms | 542.29 ms | 39.83 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a510d1d | 5.94 MiB | 6.96 MiB | 1.02 MiB |
8fa3934 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
1d47eb7 | 6.16 MiB | 7.14 MiB | 1010.29 KiB |
68677de | 6.06 MiB | 7.10 MiB | 1.04 MiB |
0a23f98 | 6.06 MiB | 7.03 MiB | 996.97 KiB |
3de8b9b | 6.27 MiB | 7.20 MiB | 957.75 KiB |
bd75526 | 6.49 MiB | 7.56 MiB | 1.07 MiB |
c1bb00f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
211a7aa | 6.06 MiB | 7.03 MiB | 997.24 KiB |
04211b9 | 6.49 MiB | 7.57 MiB | 1.08 MiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2530 +/- ##
==========================================
+ Coverage 86.97% 91.99% +5.02%
==========================================
Files 265 89 -176
Lines 9413 3087 -6326
==========================================
- Hits 8187 2840 -5347
+ Misses 1226 247 -979 ☔ View full report in Codecov by Sentry. |
vaind
requested review from
krystofwoldrich,
stefanosiano and
buenaflor
as code owners
December 22, 2024 14:39
buenaflor
reviewed
Dec 23, 2024
buenaflor
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Sending binary data (uint8list) over method channels is rather slow so instead, we allocate the memory directly in dart and only send the address and length & restore the object in objective-c.
Following screenshots show profiling flamechart (combined data) over 20-ish seconds before and after this PR. I've highlighted the relevant part
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps