Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Mark Sentry.currentHub as deprecated #406

Merged
merged 3 commits into from
Apr 6, 2021
Merged

Fix: Mark Sentry.currentHub as deprecated #406

merged 3 commits into from
Apr 6, 2021

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented Apr 6, 2021

📜 Description

Sentry.currentHub was marked deprecated.

💡 Motivation and Context

#405

💚 How did you test it?

All tests are still green.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

ueman
ueman commented Apr 6, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
marandaneto
marandaneto approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ueman ueman merged commit f840ddf into main Apr 6, 2021
@ueman ueman deleted the fix/mark-current-hub-deprecated branch April 6, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ueman @marandaneto