Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich Dart context with isolate name #600

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

kuhnroyal
Copy link
Contributor

📜 Description

Enrich Dart context with isolate name

💡 Motivation and Context

💚 How did you test it?

Add a test :)

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

none

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #600 (617c8ff) into main (6ebc780) will increase coverage by 1.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
+ Coverage   90.37%   92.09%   +1.71%     
==========================================
  Files          89        7      -82     
  Lines        2951      253    -2698     
==========================================
- Hits         2667      233    -2434     
+ Misses        284       20     -264     
Impacted Files Coverage Δ
dart/lib/src/isolate_error_integration.dart
dart/lib/src/transport/rate_limit_category.dart
...art/lib/src/http_client/failed_request_client.dart
dart/lib/src/version.dart
dart/lib/src/sentry_sampling_context.dart
dart/lib/src/hub_adapter.dart
dart/lib/src/protocol/sentry_device.dart
dart/lib/src/http_client/breadcrumb_client.dart
dart/lib/src/protocol/sentry_app.dart
dart/lib/src/transport/rate_limiter.dart
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ebc780...617c8ff. Read the comment docs.

* only add if null
* add PR to changelog
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks @kuhnroyal

@marandaneto marandaneto merged commit e159529 into getsentry:main Sep 24, 2021
@kuhnroyal kuhnroyal deleted the feature/isolate branch October 19, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enrich events with isolate name
4 participants