Fix: hangs if is empty and SDK NoOp #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueman
reviewed
Jul 4, 2022
| @@ -13,7 +15,7 @@ | |||
|
|
|||
| ### Fixes | |||
|
|
|||
| - Send DidBecomeActiveNotification when OOM enabled (#905) | |||
| * Send DidBecomeActiveNotification when OOM enabled (#905) | |||
There was a problem hiding this comment.
The auto-updater uses -, that should probably be aligned?
There was a problem hiding this comment.
Most likely, good catch, auto formatter changed automatically for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix: hangs if is empty and SDK NoOp
💡 Motivation and Context
Fixes #908
sdkis a late var and was not init for the NoOp Hub.💚 How did you test it?
📝 Checklist
🔮 Next steps