Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maps with Key Object, Object would fail during serialization if not String, Object #935

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jul 7, 2022

📜 Description

Maps with Key Object, Object would fail during serialization if not String, Object

💡 Motivation and Context

Fixes #898

💚 How did you test it?

Running it

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto requested a review from brustolin as a code owner July 7, 2022 08:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #935 (bed2386) into main (872c63d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
+ Coverage   89.80%   89.81%   +0.01%     
==========================================
  Files         104      104              
  Lines        3207     3211       +4     
==========================================
+ Hits         2880     2884       +4     
  Misses        327      327              
Impacted Files Coverage Δ
dart/lib/src/protocol/breadcrumb.dart 100.00% <100.00%> (ø)
dart/lib/src/protocol/mechanism.dart 100.00% <100.00%> (ø)
dart/lib/src/protocol/sentry_event.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 872c63d...bed2386. Read the comment docs.

Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit 3f0e852 into main Jul 7, 2022
@marandaneto marandaneto deleted the fix/crumb-InternalLinkedHashMap branch July 7, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_TypeError (type '_InternalLinkedHashMap<Object?, Object?>' is not a subtype of type 'Map<String, dynamic>?')
3 participants