-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apple): Replay Redact #11418
feat(apple): Replay Redact #11418
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just have some minor nitpicks on grammar & small question about using ignoreView
without disabling the default
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
Bundle ReportChanges will increase total bundle size by 14.09MB (99.77%) ⬆️
ℹ️ *Bundle size includes cached data from a previous commit |
@brustolin please rebase this on master, then the pr should be un-blocked! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! I left a few edits, but overall it looks great.
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to explain the difference between redact and ignore, cause I don't get it 😅
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
|
||
## Redact by View class | ||
|
||
You can choose which type of view you want to redact or ignore by using the `redactViewClasses` or `ignoreViewClasses` options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
h
: After reading this and the whole document, I'm still unsure of the difference between redact and ignore. Can we add a short explanation, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The document was updated. Please take another look
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@@ -0,0 +1,66 @@ | |||
--- | |||
title: Using Custom Redact for Session Replay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we name it Privacy
similar to the JS sdk? https://docs.sentry.io/platforms/javascript/session-replay/privacy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont know, should we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add here the resume/pause
functionality, and I think in this case it'd make sense to rename it as it's not only custom redaction/masking anymore. Maybe Privacy Controls
or something like that would do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I will improve in another doc. This is waiting for too long
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's clearer to me now. LGTM
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one note but LGTM
|
||
<Alert> | ||
|
||
If you choose to use custom masking in your Session Replays, you may accidentally expose sensitive customer data. Be sure to double-check what you choose to expose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's because for that they must disable the default masking, right?
Worth calling that out?
@lizokm might have ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just an extra reminder, so the user understands the severity of it.
Lets add the min version need for this. We can remove later when we GA the whole thing and remove the |
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
Adding instructions on how to use custom redact APIs for Apple SDK.