Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update sorting order for guides on platform filter #11547

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

chargome
Copy link
Member

@chargome chargome commented Oct 11, 2024

Based on feedback that the node guide is not immediately visible for filtering SDKs for node.

Before:

Screenshot 2024-10-11 at 11 57 57

After:

Screenshot 2024-10-11 at 11 57 41

@chargome chargome self-assigned this Oct 11, 2024
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 10:28am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 10:28am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 10:28am

Copy link

codecov bot commented Oct 11, 2024

Bundle Report

Changes will increase total bundle size by 297 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.51MB 150 bytes (0.0%) ⬆️
sentry-docs-edge-server-array-push 257.08kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.44MB 150 bytes (0.0%) ⬆️

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @chargome, thanks for updating! Is there a way to also change this for when you're filtering for platforms in the docs? The same issue is happening there...

@chargome
Copy link
Member Author

@lizokm I added it also to the platform selector in the sidebar (I hope that's what you meant 😅 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants