fix: Ensure diff code block lines are formatted correctly #11569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will decrease total bundle size by 99 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
|
turns out this was caused by the specific code block language selection rather than a style bug. Closing this PR and will open another one in a sec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the negative margin from the changed lines in the diff view to fix the vertical alignment of the changed and unchanged lines I noticed in #11568.
I'm not sure if this is the best way to fix this so please feel free to close the PR in favour of a better solution! Especially because it seems like we added the negative margin specifically to fix formatting previously in https://github.com/getsentry/sentry-docs/pull/10996/files.
potentially fixes #11568
before:
after:
