Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest not to use SentryGlobalGraphQLFilter in newer SDK versions #11832

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Nov 15, 2024

DESCRIBE YOUR PR

Ref: getsentry/sentry-javascript#14292

We don't want to suggest using this class because it is problematic. Also SentryGlobalGenericFilter is deprecated but necessary for now.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 1:27pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 1:27pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 1:27pm

Copy link

codecov bot commented Nov 15, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 8.59MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 8.94MB 6 bytes (-0.0%) ⬇️

@lforst lforst merged commit be22993 into master Nov 19, 2024
11 checks passed
@lforst lforst deleted the lforst-dont-mention-depr-nestjs-apis branch November 19, 2024 20:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants