Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration page for Dart and Flutter v7 #6090

Merged
merged 15 commits into from
Jan 20, 2023
Merged

Migration page for Dart and Flutter v7 #6090

merged 15 commits into from
Jan 20, 2023

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jan 17, 2023 •
edited
Loading

@vercel
Copy link

vercel bot commented Jan 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 4:48PM (UTC)

@marandaneto marandaneto mentioned this pull request Jan 17, 2023
Merged
5 tasks
@marandaneto marandaneto marked this pull request as ready for review January 17, 2023 14:09
@marandaneto marandaneto requested a review from a team as a code owner January 17, 2023 14:09
@marandaneto marandaneto requested a review from lizokm January 17, 2023 14:09
krystofwoldrich
krystofwoldrich approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

lizokm
lizokm reviewed Jan 17, 2023
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I'm not certain that I'm interpreting this correctly. Please let me know if I've changed the intended meaning or if you want to talk about any of the suggestions.

src/platforms/dart/migration.mdx Outdated Show resolved Hide resolved
src/platforms/dart/migration.mdx Outdated Show resolved Hide resolved
src/platforms/dart/migration.mdx Outdated Show resolved Hide resolved
src/platforms/dart/migration.mdx Outdated Show resolved Hide resolved
src/platforms/dart/migration.mdx Outdated Show resolved Hide resolved
src/platforms/dart/migration.mdx Outdated Show resolved Hide resolved
marandaneto and others added 5 commits January 18, 2023 09:15
@marandaneto @lizokm
Update src/platforms/dart/migration.mdx
4ba323f 
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@marandaneto @lizokm
Update src/platforms/dart/migration.mdx
e3df6ec 
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@marandaneto @lizokm
Update src/platforms/dart/migration.mdx
76e88cc 
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@marandaneto @lizokm
Update src/platforms/dart/migration.mdx
023fa0f 
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@marandaneto @lizokm
Update src/platforms/dart/migration.mdx
13c6376 
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@marandaneto
Copy link
Contributor Author

@lizokm I've applied the suggestions and did a few fixes as well, this is ready for re-review.
Thanks in advance.

@marandaneto marandaneto requested a review from lizokm January 18, 2023 08:30
lizokm
lizokm approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! Just a few small tweaks.

src/platforms/flutter/migration.mdx Outdated Show resolved Hide resolved
src/platforms/dart/migration.mdx Outdated Show resolved Hide resolved
src/platforms/dart/migration.mdx Outdated Show resolved Hide resolved
marandaneto and others added 3 commits January 20, 2023 17:34
@marandaneto @lizokm
Update src/platforms/flutter/migration.mdx
b4e1368 
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@marandaneto @lizokm
Update src/platforms/dart/migration.mdx
4e3a4f4 
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@marandaneto @lizokm
Update src/platforms/dart/migration.mdx
c4429e5 
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@marandaneto marandaneto enabled auto-merge (squash) January 20, 2023 16:35
@marandaneto marandaneto merged commit 6b36909 into master Jan 20, 2023
@marandaneto marandaneto deleted the chore/dartv7 branch January 20, 2023 16:43
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@lizokm lizokm lizokm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marandaneto @lizokm @krystofwoldrich