Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sourcemaps): Update sourcemaps index.mdx to highlight the React Native documentation regarding Source Map generation #8849

Closed
wants to merge 1 commit into from

Conversation

julianD77
Copy link

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

  • Include a note to ensure readers check the React Native documentation to confirm how to enable Source Maps for their platform and App build configuration

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Extra resources

Include a note to ensure readers check the React Native documentation to confirm how to enable Source Maps for their platform and App build configuration
@julianD77 julianD77 requested a review from a team as a code owner January 10, 2024 12:20
Copy link

vercel bot commented Jan 10, 2024

@julianD77 is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@julianD77
Copy link
Author

julianD77 commented Jan 10, 2024

Ive created this PR because I couldn't see any mention here of the need to make sure that the SOURCEMAP_FILE environment variable is defined on iOS in order to trigger React Native to generate source maps as part of its build process.

I can appreciate this is part of the React Native documentation and so not required in the Sentry documentation, but it may help others to be prompted to check the RN documentation too to help resolve issues.

Here is the relevant page for the RN 0.72 documentation: https://reactnative.dev/docs/0.72/sourcemaps

This a new page that was added in the RN 0.71 documentation onwards here: facebook/react-native-website#3293

@julianD77 julianD77 changed the title Update sourcemaps index.mdx to highlight the React Native documentation regarding Source Map generation docs(sourcemaps): Update sourcemaps index.mdx to highlight the React Native documentation regarding Source Map generation Jan 10, 2024
Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 0:51am

@shanamatthews
Copy link
Contributor

Hey @julianD77 - I believe the instructions on this page cover (or at least refer to) configuring your RN setup to generate source maps. @krystofwoldrich - what do you think?

@getsantry
Copy link
Contributor

getsantry bot commented Feb 1, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Feb 1, 2024
@lizokm lizokm closed this Feb 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants