Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Java Backpressure Option #9539

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

adinauer
Copy link
Member

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Describe your changes here. If your PR relates to or resolves an issue, add a link to that too.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Extra resources

Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 0:10am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 0:10am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 0:10am

@adinauer adinauer self-assigned this Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.36MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.28MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small tweaks, otherwise this looks great. Thanks for updating!

docs/platforms/java/common/configuration/options.mdx Outdated Show resolved Hide resolved
docs/platforms/java/common/configuration/sampling.mdx Outdated Show resolved Hide resolved
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@getsantry getsantry bot added the Stale label May 1, 2024
@getsantry
Copy link
Contributor

getsantry bot commented May 1, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@adinauer adinauer added wip and removed Stale labels May 2, 2024
@adinauer adinauer marked this pull request as ready for review June 5, 2024 07:48
@adinauer adinauer requested a review from lbloder June 5, 2024 07:48
@adinauer
Copy link
Member Author

adinauer commented Jun 5, 2024

I've rephrased some things to reflect the current state more accurately. @lbloder can you give this another pass 🙏

@getsantry
Copy link
Contributor

getsantry bot commented Nov 5, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Nov 5, 2024
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an optional wording suggestion, otherwise LGTM

Co-authored-by: Lukas Bloder <lukas.bloder@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants