Skip to content

Commit

Permalink
chore: remove unnecessary todo
Browse files Browse the repository at this point in the history
  • Loading branch information
vaind committed Oct 16, 2023
1 parent 17133c3 commit eb30270
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions src/Sentry.Bindings.Native/Sentry.Bindings.Native.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,10 @@
<SentryNativeOutputDirectory-win-x64>$(SentryNativeOutputDirectory)$(NativeLibRelativePath-win-x64)</SentryNativeOutputDirectory-win-x64>
<NativeLibRelativePath-linux-x64>linux-x64\native\</NativeLibRelativePath-linux-x64>
<SentryNativeOutputDirectory-linux-x64>$(SentryNativeOutputDirectory)$(NativeLibRelativePath-linux-x64)</SentryNativeOutputDirectory-linux-x64>
<!-- TODO conditional
<SentryNativeEnabled>false</SentryNativeEnabled>
<SentryNativeEnabled Condition="'$(TargetPlatformIdentifier)' == 'windows'">true</SentryNativeEnabled> -->
<SentryNativeEnabled>true</SentryNativeEnabled>
</PropertyGroup>

<!-- Packaging -->
<ItemGroup Condition="$(SentryNativeEnabled)">
<ItemGroup>
<!-- Use a separate readme file in the nuget. -->
<None Remove="$(MSBuildThisFileDirectory)..\..\README.md" />
<None Include="$(MSBuildThisFileDirectory)README.md"
Expand Down Expand Up @@ -63,7 +59,7 @@
<!-- Build the Sentry Native SDK -->
<Target Name="_BuildSentryNativeSDK-win-x64"
BeforeTargets="DispatchToInnerBuilds;BeforeBuild"
Condition="$(SentryNativeEnabled) and $([MSBuild]::IsOsPlatform('Windows'))"
Condition="$([MSBuild]::IsOsPlatform('Windows'))"
Inputs="..\..\.git\modules\modules\sentry-native\HEAD;$(MSBuildThisFileDirectory)Sentry.Bindings.Native.csproj"
Outputs="$(SentryNativeOutputDirectory-win-x64)$(SentryNativeLibraryName).lib;$(SentryNativeOutputDirectory-win-x64)$(SentryNativeLibraryName).pdb">
<MSBuild Projects="$(MSBuildProjectFile)"
Expand Down Expand Up @@ -99,7 +95,7 @@

<Target Name="_BuildSentryNativeSDK-linux-x64"
BeforeTargets="DispatchToInnerBuilds;BeforeBuild"
Condition="$(SentryNativeEnabled) and $([MSBuild]::IsOsPlatform('Linux'))"
Condition="$([MSBuild]::IsOsPlatform('Linux'))"
Inputs="..\..\.git\modules\modules\sentry-native\HEAD;$(MSBuildThisFileDirectory)Sentry.Bindings.Native.csproj"
Outputs="$(SentryNativeOutputDirectory-linux-x64)lib$(SentryNativeLibraryName).a">
<MSBuild Projects="$(MSBuildProjectFile)"
Expand Down

0 comments on commit eb30270

Please sign in to comment.