Skip to content

Commit

Permalink
Applied review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
jamescrosswell committed Mar 6, 2024
1 parent 80be4dd commit ffef982
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/Sentry/Ben.BlockingDetector/BlockingMonitor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,14 @@ public void BlockingStart(DetectionSource detectionSource)
{
Type = "BlockingCallDetector",
Handled = false,
Description = "Blocking calls can cause ThreadPool starvation."
Description = "Blocking calls can cause ThreadPool starvation.",
Source = detectionSource.ToString()
},
Type = "Blocking call detected",
Stacktrace = stackTrace,
}
},
};
evt.SetTag("DetectionSource", detectionSource.ToString());

_getHub().CaptureEvent(evt);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Sentry/Ben.BlockingDetector/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Files from Ben Adam's `Ben.BlockingDetector` at `fce6c534dfcee6ba8cb3ef74d246211
https://github.com/benaadams/Ben.BlockingDetector/blob/fce6c534dfcee6ba8cb3ef74d246211b81f5cbeb/

Sentry's core package's goal is to be dependency-free. Because of that we use different strategies of vendoring-in code.
`Ben.Demystifier` for comes in through git submodule, and a commit changing all types to `internal` is added.
`Ben.Demystifier` for example comes in through git submodule, and a commit changing all types to `internal` is added.

Here, since no changes were done to this project in years, and it's just a handful of files,
we're directly copying and changing them.
Expand Down

0 comments on commit ffef982

Please sign in to comment.