-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suspicious warning messages with tracing enabled (Trying to close a span that was already garbage collected) #1350
Comments
Thanks for raising @ZlobnyiSerg |
#1368 will resolve this problem. |
Should be fixed on 3.12.1. |
I've updated to 3.12.1, now we have less warnings but they're still there. For example:
|
@bruno-garcia I can't reopen this issue, maybe I have no rights? |
We need to replace the logic that holds the spans references from here sentry-dotnet/src/Sentry.DiagnosticSource/Internals/DiagnosticSource/SentryEFCoreListener.cs Lines 43 to 45 in 12c46e1
One approach that could be followed is to do something similar to what was done on SqlListener sentry-dotnet/src/Sentry.DiagnosticSource/Internals/DiagnosticSource/SentrySqlListener.cs Line 92 in 12c46e1
sentry-dotnet/src/Sentry.DiagnosticSource/Internals/DiagnosticSource/SentrySqlListener.cs Lines 176 to 177 in 12c46e1
Where we store the spans directly into the Scope transaction and locate them by the OperationId given by KeyValuePair<string, object?> value .
|
@lucas-zimerman - Any update on this one? |
The warning noise was reduced on #1368. As pointed on this comment #1350 (comment) the current code doesn't work correctly with multiple connections/queries on the same transaction, Ideally we could follow what was implemented on SentrySqlListener where the spans are located inside of the current active Transaction instead of an AsyncLocal WeakReference. But so far this change in the code wasn't developed |
When this noise will be cancelled ? |
I'm pretty sure all of the above will be addressed in Fix/DB Connection spans presented poorly #2409. The I'll leave this issue open until the fix above is made available in the next release. |
Closing this issues as it should be fixed with the 3.33.1 release. |
Environment
Steps to Reproduce
app.UseSentryTracing()
)Expected Result
No warnings in log file from Sentry
Actual Result
Lot of warning messages coming from Sentry:
I'm not sure if this is critical for functioning, but this makes noise in logs (with default configuration). I had to raise level for Sentry to Error.
If this is intended behaviour, please close this issue.
The text was updated successfully, but these errors were encountered: