-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect order when getting the last active span. #1094
Conversation
Thank you! Can you please add a changelog entry inside Changelog.md/Unreleased/Fixes section?
|
Codecov Report
@@ Coverage Diff @@
## main #1094 +/- ##
==========================================
- Coverage 80.70% 79.06% -1.64%
==========================================
Files 194 194
Lines 6359 6359
Branches 1411 1411
==========================================
- Hits 5132 5028 -104
- Misses 764 876 +112
+ Partials 463 455 -8
Continue to review full report at Codecov.
|
Thanks @robersonliou ! |
@bruno-garcia It seems nothing update in |
Here is an active span order issue.
when I started multi active span in the same transaction, the span tree in sentry ui was not what I expected.
For example, it should be:
but what I got was:
Here is the actual screenshot:
I've traced the source code, and found this issue was cause by
TransactionTrace.GetLastActiveSpan()
.The
TransactionTrace
stored the ongoing span in theConcurrentBag<ISpan>
, it worked fine!But the default order of
ConcurrentBag
is just like FILO, if I put several active spans sequentially, the result would like as following table:It could be solved by reordering the span.