Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cancel cache flushing on init #1139

Merged
merged 6 commits into from
Jul 21, 2021
Merged

Don't cancel cache flushing on init #1139

merged 6 commits into from
Jul 21, 2021

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Jul 21, 2021

Closes #1071

@Tyrrrz Tyrrrz added Feature New feature or request Offline Caching labels Jul 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #1139 (c16606c) into main (46bcd9f) will decrease coverage by 1.46%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1139      +/-   ##
==========================================
- Coverage   80.75%   79.29%   -1.47%     
==========================================
  Files         200      200              
  Lines        6615     6617       +2     
  Branches     1464     1465       +1     
==========================================
- Hits         5342     5247      -95     
- Misses        802      908     +106     
+ Partials      471      462       -9     
Impacted Files Coverage Δ
src/Sentry/Internal/SdkComposer.cs 42.22% <27.27%> (+5.01%) ⬆️
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 0.00% <0.00%> (-100.00%) ⬇️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 0.00% <0.00%> (-70.43%) ⬇️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 4.54% <0.00%> (-68.19%) ⬇️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 25.00% <0.00%> (-37.50%) ⬇️
...ntry/Integrations/NetFxInstallationsIntegration.cs 28.57% <0.00%> (-28.58%) ⬇️
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 54.23% <0.00%> (-5.09%) ⬇️
src/Sentry/Internal/AppDomainAdapter.cs 66.66% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46bcd9f...c16606c. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on the call best to inline the logic and avoid the task cancelled exxception then

CHANGELOG.md Outdated Show resolved Hide resolved
Tyrrrz and others added 3 commits July 21, 2021 22:05
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
@Tyrrrz Tyrrrz requested a review from bruno-garcia July 21, 2021 19:08
@bruno-garcia bruno-garcia merged commit a0b454b into main Jul 21, 2021
@bruno-garcia bruno-garcia deleted the improve-init-flush branch July 21, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request Offline Caching
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve flush on init
3 participants