feat: Breadcrumbs for sessions #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
requested review from
bruno-garcia and
lucas-zimerman
as code owners
|
Codecov Report
@@ Coverage Diff @@
## main #1263 +/- ##
==========================================
+ Coverage 81.82% 81.83% +0.01%
==========================================
Files 212 212
Lines 7070 7075 +5
Branches 1396 1396
==========================================
+ Hits 5785 5790 +5
Misses 845 845
Partials 440 440
Continue to review full report at Codecov.
|
src/Sentry/GlobalSessionManager.cs
Outdated
| @@ -398,6 +402,8 @@ public IReadOnlyList<SessionUpdate> ResumeSession() | |||
| return Array.Empty<SessionUpdate>(); | |||
| } | |||
|
|
|||
| AddSessionBreadcrumb("Resuming Session"); | |||
There was a problem hiding this comment.
What about being specific that this is a Sentry session?
Suggested change
| AddSessionBreadcrumb("Resuming Session"); | |
| AddSessionBreadcrumb("Sentry resuming session"); |
|
Lucas offered to tidy up the missing notes and merge this one. Thank |
bruno-garcia
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With debug logging disabled sessions leave no trace. I took
TypeandCategoryfrom the Java SDK: https://github.com/getsentry/sentry-java/blob/main/sentry-android-core/src/main/java/io/sentry/android/core/LifecycleWatcher.java#L130-L137