-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MemoryInfo to sentry event #1337
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1337 +/- ##
==========================================
+ Coverage 81.36% 83.01% +1.65%
==========================================
Files 216 217 +1
Lines 7180 7295 +115
Branches 1410 1411 +1
==========================================
+ Hits 5842 6056 +214
+ Misses 912 804 -108
- Partials 426 435 +9
Continue to review full report at Codecov.
|
I like this! |
@bruno-garcia does this need extra tests? and if so, is there any similar tests i can use as a template? |
I'm looking at tests on MainEventProcessor and some make sense: sentry-dotnet/test/Sentry.Tests/Internals/MainSentryEventProcessorTests.cs Lines 445 to 460 in ad9f5ff
Though things that have side effect are not being rolled back, now that I see it. Like: sentry-dotnet/test/Sentry.Tests/Internals/MainSentryEventProcessorTests.cs Lines 434 to 435 in ad9f5ff
|
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,5 +1,11 @@ | |||
# Changelog | |||
|
|||
## Unreleased | |||
|
|||
### Fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, we should've added this as feature. Rolled out as 3.12.3
fixes #627