-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dont fail for attachment read error #1378
Conversation
instead log to DiagnosticLogger
…om/getsentry/sentry-dotnet into dont-fail-for-attachment-exception
Codecov Report
@@ Coverage Diff @@
## main #1378 +/- ##
=======================================
Coverage 82.67% 82.67%
=======================================
Files 215 215
Lines 7152 7159 +7
Branches 1408 1410 +2
=======================================
+ Hits 5913 5919 +6
Misses 805 805
- Partials 434 435 +1
Continue to review full report at Codecov.
|
Since the net6 upgrade, Ben.Demystifier tests got flaky:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Thanks!
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
} | ||
catch (Exception exception) | ||
{ | ||
if (logger is null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out we continue to fail because no logger is passed when Debug=false
instead log to DiagnosticLogger
related to #1375