Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CaptureLastError for ASP.NET #1411

Merged
merged 9 commits into from
Jan 3, 2022
Merged

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Dec 22, 2021

Simplifies the process of capturing exceptions on ASP.NET. Additionally, it also flags the errors as unhandled.

Update #1411 once merged.

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2021

Codecov Report

Merging #1411 (c182e72) into main (2254df3) will increase coverage by 0.01%.
The diff coverage is 83.33%.

❗ Current head c182e72 differs from pull request most recent head 4428206. Consider uploading reports for the commit 4428206 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1411      +/-   ##
==========================================
+ Coverage   84.12%   84.13%   +0.01%     
==========================================
  Files         218      219       +1     
  Lines        7351     7357       +6     
  Branches     1415     1416       +1     
==========================================
+ Hits         6184     6190       +6     
- Misses        727      728       +1     
+ Partials      440      439       -1     
Impacted Files Coverage Δ
...Sentry.AspNet/SentryHttpServerUtilityExtensions.cs 83.33% <83.33%> (ø)
src/Sentry/Exceptions/Mechanism.cs 85.29% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2254df3...4428206. Read the comment docs.

@lucas-zimerman lucas-zimerman marked this pull request as ready for review December 22, 2021 17:35
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lucas

@bruno-garcia bruno-garcia merged commit e0224eb into main Jan 3, 2022
@bruno-garcia bruno-garcia deleted the ref/aspnet-error-capture branch January 3, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants