Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added overloads to Capture methods to replace WithScope #1412

Merged
merged 18 commits into from
Jan 14, 2022

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Dec 22, 2021

Aims to solve: #675

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but we can't remove the public API just yet.
And we'll need to run the Verify snapshot to get the new API diff

src/Sentry/IHub.cs Outdated Show resolved Hide resolved
src/Sentry/Extensibility/HubAdapter.cs Show resolved Hide resolved
src/Sentry/HubExtensions.cs Outdated Show resolved Hide resolved
src/Sentry/HubExtensions.cs Outdated Show resolved Hide resolved
src/Sentry/HubExtensions.cs Outdated Show resolved Hide resolved
@bitsandfoxes bitsandfoxes changed the title draft: Replace WithScope with capture overloads Added overloads to Capture methods to replace WithScope Jan 13, 2022
@bitsandfoxes bitsandfoxes marked this pull request as ready for review January 13, 2022 11:22
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #1412 (7e62175) into main (6f7d05c) will increase coverage by 1.31%.
The diff coverage is 70.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1412      +/-   ##
==========================================
+ Coverage   82.78%   84.10%   +1.31%     
==========================================
  Files         219      219              
  Lines        7350     7374      +24     
  Branches     1409     1411       +2     
==========================================
+ Hits         6085     6202     +117     
+ Misses        838      735     -103     
- Partials      427      437      +10     
Impacted Files Coverage Δ
src/Sentry/Extensibility/DisabledHub.cs 61.53% <0.00%> (-2.47%) ⬇️
src/Sentry/Extensibility/HubAdapter.cs 70.58% <0.00%> (-2.14%) ⬇️
src/Sentry/Internal/Hub.cs 72.39% <57.14%> (-0.58%) ⬇️
src/Sentry/HubExtensions.cs 87.23% <83.33%> (-1.34%) ⬇️
src/Sentry/SentrySdk.cs 82.81% <100.00%> (+0.84%) ⬆️
src/Sentry/Internal/AppDomainAdapter.cs 66.66% <0.00%> (ø)
src/Sentry/Exceptions/Mechanism.cs 85.29% <0.00%> (+2.94%) ⬆️
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 58.62% <0.00%> (+5.17%) ⬆️
...ntry/Integrations/NetFxInstallationsIntegration.cs 57.14% <0.00%> (+28.57%) ⬆️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 62.50% <0.00%> (+37.50%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f7d05c...7e62175. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits, otherwise LGTM

src/Sentry/Extensibility/HubAdapter.cs Outdated Show resolved Hide resolved
src/Sentry/HubExtensions.cs Outdated Show resolved Hide resolved
src/Sentry/SentrySdk.cs Show resolved Hide resolved
@bitsandfoxes bitsandfoxes merged commit 6f35bc4 into main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants