Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackgroundWorker: make types public #1450

Merged
merged 6 commits into from
Jan 29, 2022
Merged

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Jan 29, 2022

Following the experiment to add WebGL to Unity, we learned that we need to change the BackgroundWorker implementation.

See also: #1207

@bruno-garcia bruno-garcia changed the title make types and members public BackgroundWorker: make types public Jan 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2022

Codecov Report

Merging #1450 (d75135e) into main (42917d9) will increase coverage by 0.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1450      +/-   ##
==========================================
+ Coverage   82.13%   82.83%   +0.69%     
==========================================
  Files         219      219              
  Lines        7374     7374              
  Branches     1412     1412              
==========================================
+ Hits         6057     6108      +51     
+ Misses        906      839      -67     
- Partials      411      427      +16     
Impacted Files Coverage Δ
src/Sentry/Envelopes/Envelope.cs 96.77% <ø> (ø)
src/Sentry/Envelopes/EnvelopeItem.cs 93.07% <ø> (ø)
src/Sentry/SentryOptions.cs 90.30% <100.00%> (ø)
src/Sentry/Internal/BackgroundWorker.cs 93.47% <0.00%> (+1.44%) ⬆️
src/Sentry/Internal/Hub.cs 73.95% <0.00%> (+1.56%) ⬆️
src/Sentry/Exceptions/SentryException.cs 96.77% <0.00%> (+16.12%) ⬆️
src/Sentry/Exceptions/Mechanism.cs 82.35% <0.00%> (+26.47%) ⬆️
src/Sentry/Exceptions/SentryStackFrame.cs 81.70% <0.00%> (+29.26%) ⬆️
src/Sentry/Exceptions/SentryStackTrace.cs 93.75% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42917d9...d75135e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants