Avoid calls the Thread.CurrentThread where possible #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonCropp
requested review from
bruno-garcia and
lucas-zimerman
as code owners
| @@ -103,7 +103,7 @@ internal IEnumerable<SentryException> CreateSentryException(Exception exception) | |||
| Type = exception.GetType()?.FullName, | |||
| Module = exception.GetType()?.Assembly?.FullName, | |||
| Value = exception.Message, | |||
| ThreadId = Thread.CurrentThread.ManagedThreadId, | |||
| ThreadId = Environment.CurrentManagedThreadId, | |||
There was a problem hiding this comment.
Shouldn't we add a test that invokes MainExceptionProcessor and MainSentryEventProcessor to check if ThreadId and SentryThread.Id are equal?
Other than that, the PR looks good for me.
Codecov Report
@@ Coverage Diff @@
## main #1466 +/- ##
==========================================
- Coverage 84.26% 84.24% -0.03%
==========================================
Files 219 219
Lines 7387 7388 +1
Branches 1417 1417
==========================================
- Hits 6225 6224 -1
- Misses 727 728 +1
- Partials 435 436 +1
Continue to review full report at Codecov.
|
bruno-garcia
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.